-
-
Notifications
You must be signed in to change notification settings - Fork 159
perf(codegen): streamline async control cells #8012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
proggeramlug
merged 2 commits into
PerryTS:main
from
proggeramlug:perf/8008-asyncpipe-gap
Aug 13, 2026
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| ### Faster compiler-private async control cells (#8008) | ||
|
|
||
| Async and generator state machines now access their compiler-minted state, | ||
| pending-type, done, and executing cells with direct typed loads and stores. | ||
| Those cells are preallocated as single-field `I32Box` or `BoolBox` values, so | ||
| their pointer provenance and representation are already proven; routing every | ||
| access through the general runtime helpers redundantly checked the same pointer | ||
| against a thread-local box registry. | ||
|
|
||
| Ordinary user captures keep the checked runtime path, including its invalid-box | ||
| protection. Primitive allocation and registry insertion also remain unchanged; | ||
| only access to the four private controls bypasses repeated validation. | ||
|
|
||
| On the refreshed async probe set this removes 7.08% of retired instructions | ||
| from the pure async/await topology, 5.92% when plain objects flow through the | ||
| same topology, and 2.10% from the full `asyncpipe` workload. The synchronous | ||
| and Promise.all-only controls remain flat. An IR regression locks down both | ||
| the narrow eligibility boundary and the direct typed accesses. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: PerryTS/perry
Length of output: 50372
🏁 Script executed:
Repository: PerryTS/perry
Length of output: 50370
🏁 Script executed:
Repository: PerryTS/perry
Length of output: 50371
🏁 Script executed:
Repository: PerryTS/perry
Length of output: 50372
🏁 Script executed:
Repository: PerryTS/perry
Length of output: 50370
🏁 Script executed:
Repository: PerryTS/perry
Length of output: 50370
🏁 Script executed:
Repository: PerryTS/perry
Length of output: 2472
🏁 Script executed:
Repository: PerryTS/perry
Length of output: 50370
🏁 Script executed:
Repository: PerryTS/perry
Length of output: 50370
🏁 Script executed:
Repository: PerryTS/perry
Length of output: 50370
🏁 Script executed:
Repository: PerryTS/perry
Length of output: 50369
🏁 Script executed:
Repository: PerryTS/perry
Length of output: 50370
🏁 Script executed:
Repository: PerryTS/perry
Length of output: 12687
🏁 Script executed:
Repository: PerryTS/perry
Length of output: 50370
🏁 Script executed:
Repository: PerryTS/perry
Length of output: 13622
Avoid name-based classification of user locals
A preallocated user binding named
__gen_state,__gen_pending_type,__gen_done, or__gen_executingmatches the compiler-private classifier incrates/perry-codegen/src/boxed_vars.rs:1427-1438. Its writes then use primitive-cell lowering, so a Number binding can be truncated to i32. Use compiler-generated IDs or reserve these names. Add a regression with a captured user binding.🤖 Prompt for AI Agents
Source: Coding guidelines