-
-
Notifications
You must be signed in to change notification settings - Fork 155
ci: install clang-22 in setup-llvm22 and assert the pair #7388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| **Fixed** `setup-llvm22` installed LLVM 22's development libraries without | ||
| `clang-22`, leaving `/usr/lib/llvm-22/bin/opt` with no clang beside it. | ||
|
|
||
| apt ships opt and clang as separate packages, so `llvm-22-dev` alone produces a | ||
| half-populated bin directory — the state `ubuntu-24.04-arm` runners land in. | ||
| Consumers that need a *matched* opt+clang pair (the RS4GC arm in | ||
| `gc-native-roots.yml`) then either fail the pair-check outright or fall back to | ||
| hand-rolled discovery and install the distro's unversioned `llvm clang`, which on | ||
| Ubuntu 24.04 is LLVM 18 — running `opt` 18 over IR emitted by Perry's linked | ||
| LLVM 22. | ||
|
|
||
| The action now installs `clang-22`, symlinks it under the `llvm-config-22` | ||
| prefix so directory-based toolchain resolution finds a co-located pair, and | ||
| asserts clang's major version alongside the existing `llvm-config` check. A green | ||
| setup step that leaves a mismatched clang is precisely the failure this action | ||
| exists to prevent. | ||
|
|
||
| Fixes the root cause of #7384 for all 18 workflows rather than one. | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Qualify the
#7384claim.The PR scope leaves
gc-native-roots.ymldiscovery changes for follow-up issue#7384. Line 18 says the root cause is fixed for all 18 workflows. This overstates the documented scope. Reword the line to describe thesetup-llvm22fix without claiming that the follow-up discovery work is complete.Based on the PR objectives,
gc-native-roots.ymldiscovery remains follow-up work.Proposed changelog wording
📝 Committable suggestion
🤖 Prompt for AI Agents