Skip to content

add optional passing of fw version#27

Open
maclobdell wants to merge 2 commits into
masterfrom
add-optional-fw-version
Open

add optional passing of fw version#27
maclobdell wants to merge 2 commits into
masterfrom
add-optional-fw-version

Conversation

@maclobdell

Copy link
Copy Markdown

Resolves #26

Comment thread README.md Outdated
@teetak01 teetak01 requested a review from moshe-shahar January 18, 2021 04:36
Comment on lines +83 to +87
if fw_version is None:
cmd = [MANIFEST_DEV_TOOL, 'create-v1', '-u', firmware_url, '-o', output]
else:
cmd = [MANIFEST_DEV_TOOL, 'create-v1', '-u', firmware_url, '-o', output, '--fw-version', fw_version]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if fw_version is None:
cmd = [MANIFEST_DEV_TOOL, 'create-v1', '-u', firmware_url, '-o', output]
else:
cmd = [MANIFEST_DEV_TOOL, 'create-v1', '-u', firmware_url, '-o', output, '--fw-version', fw_version]
cmd = [MANIFEST_DEV_TOOL, 'create-v1', '-u', firmware_url, '-o', output]

Better to add it below Line 92 to include v3 too:

if fw_version:
    cmd += [ '--fw-version', fw_version ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing support for explicit firmware version

5 participants