Skip to content

Handle errors #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
philipostli merged 11 commits into from
Jul 12, 2025
Merged

Handle errors #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3dca006
Refactor error handling in pollValues method to catch unexpected errors
philipostli Jun 12, 2025
8c61eea
Add custom agent with increased maxSockets
philipostli Jun 12, 2025
a71faec
Enhance error handling in requestWithBackoff function to include data…
philipostli Jun 12, 2025
f2df176
Add proxy error handling to requestWithBackoff function for improved …
philipostli Jun 12, 2025
0bef707
Add TLS-specific settings and enhance error handling in requestWithBa…
philipostli Jun 12, 2025
87c48f3
Include longer backoff for ECONNRESET errors
philipostli Jun 12, 2025
5ee932d
Include handling for request timeouts
philipostli Jun 12, 2025
781eaca
Include DNS lookup timeout errors
philipostli Jun 12, 2025
d2716c4
Corrected TLS setting
philipostli Jun 12, 2025
ccc694d
Removed unneccesary nock types
philipostli Jun 12, 2025
f01045b
Downgrade eslint version from 8.30.0 to 7.32.0 for compatibility reas…
philipostli Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 46 additions & 38 deletions drivers/go/device.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,49 +338,57 @@ export class GoCharger extends Homey.Device {
* We should catch errors inside this function!
*/
protected pollValues() {
if (this.api === undefined) return;
try {
if (this.api === undefined) return;

// Poll charger info
this.api
.getCharger(this.getData().id)
.then((charger) => {
this.setSettings({
requireAuthentication: charger.IsAuthorizationRequired,
// Poll charger info
this.api
.getCharger(this.getData().id)
.then((charger) => {
this.setSettings({
requireAuthentication: charger.IsAuthorizationRequired,
});
})
.catch((e) => {
this.logToDebug(`Failed to poll charger info: ${e}`);
this.setUnavailable(
this.homey.__('errors.authentication_failed')
);
});
})
.catch((e) => {
this.logToDebug(`Failed to poll charger info: ${e}`);
this.setUnavailable(
this.homey.__('errors.authentication_failed')
);
});

// Poll state variables from the API.
this.api
.getChargerState(this.getData().id)
.then(async (states) => {
for (const state of states) {
// Wrap each state handling individually so that a single bad state processing
// doesn't drop all values. It makes the app more usable when it's failing.
try {
await this.handleState(state);
} catch (e) {
this.logToDebug(
`Failed to handle charger state ${state.StateId}: ${e}`,
);
// Poll state variables from the API.
this.api
.getChargerState(this.getData().id)
.then(async (states) => {
for (const state of states) {
// Wrap each state handling individually so that a single bad state processing
// doesn't drop all values. It makes the app more usable when it's failing.
try {
await this.handleState(state);
} catch (e) {
this.logToDebug(
`Failed to handle charger state ${state.StateId}: ${e}`,
);
}
}
}
})
.catch((e) => {
this.logToDebug(`Failed to poll charger state: ${e}`);
});
})
.catch((e) => {
this.logToDebug(`Failed to poll charger state: ${e}`);
});

// Poll the available current for the installation.
// TODO: Is this really necessary? Is it interesting to watch live?
// It's more likely to be changed by us?
this.pollInstallationValues().catch((e) => {
this.logToDebug(`Failed to poll available current: ${e}`);
});
// Poll the available current for the installation.
// TODO: Is this really necessary? Is it interesting to watch live?
// It's more likely to be changed by us?
this.pollInstallationValues().catch((e) => {
this.logToDebug(`Failed to poll available current: ${e}`);
});
} catch (error) {
this.logToDebug(`Unexpected error in pollValues: ${error}`);
// Avoid setting device unavailable for every error to prevent flapping
if (error instanceof Error && error.message.includes('authentication')) {
this.setUnavailable(this.homey.__('errors.authentication_failed'));
}
}
}

/**
Expand Down
86 changes: 47 additions & 39 deletions drivers/go2/device.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,49 +236,57 @@ export class Go2Charger extends Homey.Device {
* We should catch errors inside this function!
*/
protected pollValues() {
if (this.api === undefined) return;

// Poll charger info
this.api
.getCharger(this.getData().id)
.then((charger) => {
this.setSettings({
requireAuthentication: charger.IsAuthorizationRequired,
try {
if (this.api === undefined) return;

// Poll charger info
this.api
.getCharger(this.getData().id)
.then((charger) => {
this.setSettings({
requireAuthentication: charger.IsAuthorizationRequired,
});
})
.catch((e) => {
this.logToDebug(`Failed to poll charger info: ${e}`);
this.setUnavailable(
this.homey.__('errors.authentication_failed')
);
});
})
.catch((e) => {
this.logToDebug(`Failed to poll charger info: ${e}`);
this.setUnavailable(
this.homey.__('errors.authentication_failed')
);
});

// Poll state variables from the API.
this.api
.getChargerState(this.getData().id)
.then(async (states) => {
for (const state of states) {
// Wrap each state handling individually so that a single bad state processing
// doesn't drop all values. It makes the app more usable when it's failing.
try {
await this.handleState(state);
} catch (e) {
this.logToDebug(
`Failed to handle charger state ${state.StateId}: ${e}`,
);
// Poll state variables from the API.
this.api
.getChargerState(this.getData().id)
.then(async (states) => {
for (const state of states) {
// Wrap each state handling individually so that a single bad state processing
// doesn't drop all values. It makes the app more usable when it's failing.
try {
await this.handleState(state);
} catch (e) {
this.logToDebug(
`Failed to handle charger state ${state.StateId}: ${e}`,
);
}
}
}
})
.catch((e) => {
this.logToDebug(`Failed to poll charger state: ${e}`);
});
})
.catch((e) => {
this.logToDebug(`Failed to poll charger state: ${e}`);
});

// Poll the available current for the installation.
// TODO: Is this really necessary? Is it interesting to watch live?
// It's more likely to be changed by us?
this.pollInstallationValues().catch((e) => {
this.logToDebug(`Failed to poll available current: ${e}`);
});
// Poll the available current for the installation.
// TODO: Is this really necessary? Is it interesting to watch live?
// It's more likely to be changed by us?
this.pollInstallationValues().catch((e) => {
this.logToDebug(`Failed to poll available current: ${e}`);
});
} catch (error) {
this.logToDebug(`Unexpected error in pollValues: ${error}`);
// Avoid setting device unavailable for every error to prevent flapping
if (error instanceof Error && error.message.includes('authentication')) {
this.setUnavailable(this.homey.__('errors.authentication_failed'));
}
}
}

/**
Expand Down
86 changes: 47 additions & 39 deletions drivers/home/device.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,49 +334,57 @@ export class HomeCharger extends Homey.Device {
* We should catch errors inside this function!
*/
protected pollValues() {
if (this.api === undefined) return;

// Poll charger info
this.api
.getCharger(this.getData().id)
.then((charger) => {
this.setSettings({
requireAuthentication: charger.IsAuthorizationRequired,
try {
if (this.api === undefined) return;

// Poll charger info
this.api
.getCharger(this.getData().id)
.then((charger) => {
this.setSettings({
requireAuthentication: charger.IsAuthorizationRequired,
});
})
.catch((e) => {
this.logToDebug(`Failed to poll charger info: ${e}`);
this.setUnavailable(
this.homey.__('errors.authentication_failed')
);
});
})
.catch((e) => {
this.logToDebug(`Failed to poll charger info: ${e}`);
this.setUnavailable(
this.homey.__('errors.authentication_failed')
);
});

// Poll state variables from the API.
this.api
.getChargerState(this.getData().id)
.then(async (states) => {
for (const state of states) {
// Wrap each state handling individually so that a single bad state processing
// doesn't drop all values. It makes the app more usable when it's failing.
try {
await this.handleState(state);
} catch (e) {
this.logToDebug(
`Failed to handle charger state ${state.StateId}: ${e}`,
);
// Poll state variables from the API.
this.api
.getChargerState(this.getData().id)
.then(async (states) => {
for (const state of states) {
// Wrap each state handling individually so that a single bad state processing
// doesn't drop all values. It makes the app more usable when it's failing.
try {
await this.handleState(state);
} catch (e) {
this.logToDebug(
`Failed to handle charger state ${state.StateId}: ${e}`,
);
}
}
}
})
.catch((e) => {
this.logToDebug(`Failed to poll charger state: ${e}`);
});
})
.catch((e) => {
this.logToDebug(`Failed to poll charger state: ${e}`);
});

// Poll the available current for the installation.
// TODO: Is this really necessary? Is it interesting to watch live?
// It's more likely to be changed by us?
this.pollInstallationValues().catch((e) => {
this.logToDebug(`Failed to poll available current: ${e}`);
});
// Poll the available current for the installation.
// TODO: Is this really necessary? Is it interesting to watch live?
// It's more likely to be changed by us?
this.pollInstallationValues().catch((e) => {
this.logToDebug(`Failed to poll available current: ${e}`);
});
} catch (error) {
this.logToDebug(`Unexpected error in pollValues: ${error}`);
// Avoid setting device unavailable for every error to prevent flapping
if (error instanceof Error && error.message.includes('authentication')) {
this.setUnavailable(this.homey.__('errors.authentication_failed'));
}
}
}

/**
Expand Down
86 changes: 47 additions & 39 deletions drivers/pro/device.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,49 +335,57 @@ export class ProCharger extends Homey.Device {
* We should catch errors inside this function!
*/
protected pollValues() {
if (this.api === undefined) return;

// Poll charger info
this.api
.getCharger(this.getData().id)
.then((charger) => {
this.setSettings({
requireAuthentication: charger.IsAuthorizationRequired,
try {
if (this.api === undefined) return;

// Poll charger info
this.api
.getCharger(this.getData().id)
.then((charger) => {
this.setSettings({
requireAuthentication: charger.IsAuthorizationRequired,
});
})
.catch((e) => {
this.logToDebug(`Failed to poll charger info: ${e}`);
this.setUnavailable(
this.homey.__('errors.authentication_failed')
);
});
})
.catch((e) => {
this.logToDebug(`Failed to poll charger info: ${e}`);
this.setUnavailable(
this.homey.__('errors.authentication_failed')
);
});

// Poll state variables from the API.
this.api
.getChargerState(this.getData().id)
.then(async (states) => {
for (const state of states) {
// Wrap each state handling individually so that a single bad state processing
// doesn't drop all values. It makes the app more usable when it's failing.
try {
await this.handleState(state);
} catch (e) {
this.logToDebug(
`Failed to handle charger state ${state.StateId}: ${e}`,
);
// Poll state variables from the API.
this.api
.getChargerState(this.getData().id)
.then(async (states) => {
for (const state of states) {
// Wrap each state handling individually so that a single bad state processing
// doesn't drop all values. It makes the app more usable when it's failing.
try {
await this.handleState(state);
} catch (e) {
this.logToDebug(
`Failed to handle charger state ${state.StateId}: ${e}`,
);
}
}
}
})
.catch((e) => {
this.logToDebug(`Failed to poll charger state: ${e}`);
});
})
.catch((e) => {
this.logToDebug(`Failed to poll charger state: ${e}`);
});

// Poll the available current for the installation.
// TODO: Is this really necessary? Is it interesting to watch live?
// It's more likely to be changed by us?
this.pollInstallationValues().catch((e) => {
this.logToDebug(`Failed to poll available current: ${e}`);
});
// Poll the available current for the installation.
// TODO: Is this really necessary? Is it interesting to watch live?
// It's more likely to be changed by us?
this.pollInstallationValues().catch((e) => {
this.logToDebug(`Failed to poll available current: ${e}`);
});
} catch (error) {
this.logToDebug(`Unexpected error in pollValues: ${error}`);
// Avoid setting device unavailable for every error to prevent flapping
if (error instanceof Error && error.message.includes('authentication')) {
this.setUnavailable(this.homey.__('errors.authentication_failed'));
}
}
}

/**
Expand Down
Loading