Usage report calculates negative endpoint throughput after queue table deletion

[mikeminutillo]

Symptoms

Usage reports can contain negative throughput values for an endpoint/queue.

This can happen when a queue table is deleted between throughput snapshots.

Who's affected

Users generating usage reports where queue tables may have been deleted during the reporting period.

Root cause

Throughput is calculated by comparing two snapshots taken an hour apart.

When a queue table is deleted, the end-of-hour total is not set and defaults to 0, causing the calculation to produce a negative throughput value.

Confirmed workarounds

None

Original bug report

While calculating throughput, when a queue table is deleted, we see a negative throughput entry recorded in the usage report for the day.

This happens because we take two snapshots, an hour apart, and then this to figure out how many messages have been processed:

totalThroughputForHour = totalMessagesEndOfHour - totalMessagesStartOfHour

When a table gets deleted, we do not set the totalMessagesEndOfHour which results in the default value of zero. This ends up looking like this:

totalThroughputForHour = 0 - totalMessagesStartOfHour

That is always going to be a negative number, and one that is not representative of the throughput in that hour.

[mikeminutillo]

This is in alignment with how the Endpoint Throughput Counter tool does it.

[johnsimons]

LGTM