Parameter parser AWG#1408
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1408 +/- ##
============================================
- Coverage 58.44% 58.42% -0.02%
- Complexity 8667 8669 +2
============================================
Files 634 634
Lines 27991 27995 +4
============================================
- Hits 16359 16357 -2
- Misses 11632 11638 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Hmm i am not really a big fan of introducing a hardcoded special case for AWG. Something more universal would be good. |
|
I see, and I'm all for a universal solution. But parameters themselves are very generic, so Part-DB basically knows nothing about them from the start. I can think of two ways to approach this:
Possible middle ground: Show a warning instead of an error on validation failure and allow saving anyway. What do you think would be the way to go? |
Swaps the min/max AWG values if they are ordered from "small diameter" to "big diameter", i.e. "big number" to "small number".
Fixes #1351.