Skip to content

Add SanityCheck#EqualityRulesRecipes#3

Open
Pankraz76 wants to merge 1 commit into
mainfrom
fix-EqualityRulesRecipes
Open

Add SanityCheck#EqualityRulesRecipes#3
Pankraz76 wants to merge 1 commit into
mainfrom
fix-EqualityRulesRecipes

Conversation

@Pankraz76

@Pankraz76 Pankraz76 commented Dec 30, 2025 •
edited
Loading

Copy link
Copy Markdown
Owner 
Changes have been made to buildpack/spring-boot-buildpack-platform/src/main/java/org/springframework/boot/buildpack/platform/build/Cache.java by:
    tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
        tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe
Changes have been made to core/spring-boot-test/src/main/java/org/springframework/boot/test/util/TestPropertyValues.java by:
    tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
        tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe
Changes have been made to core/spring-boot-test/src/main/java/org/springframework/boot/test/system/OutputCapture.java by:
    tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
        tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityLambdaRecipe
Changes have been made to module/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/info/InfoPropertiesInfoContributor.java by:
    tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
        tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe
Changes have been made to module/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/endpoint/invoker/cache/CachingOperationInvoker.java by:
    tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
        tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe
Changes have been made to module/spring-boot-devtools/src/main/java/org/springframework/boot/devtools/filewatch/ChangedFile.java by:
    tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
        tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe
Changes have been made to module/spring-boot-jetty/src/main/java/org/springframework/boot/jetty/autoconfigure/JettyWebServerFactoryCustomizer.java by:
    tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
        tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe
Changes have been made to module/spring-boot-kafka/src/main/java/org/springframework/boot/kafka/autoconfigure/ConcurrentKafkaListenerContainerFactoryConfigurer.java by:
    tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
        tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe
Changes have been made to module/spring-boot-security/src/test/java/org/springframework/boot/security/autoconfigure/UserDetailsServiceAutoConfigurationTests.java by:
    tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
        tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityLambdaRecipe
Changes have been made to module/spring-boot-sql/src/main/java/org/springframework/boot/sql/autoconfigure/init/OnDatabaseInitializationCondition.java by:
    tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
        tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe
        tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$NegationRecipe
Changes have been made to test-support/spring-boot-test-support/src/main/java/org/springframework/boot/testsupport/system/OutputCapture.java by:
    tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
        tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityLambdaRecipe
Please review and commit the results.
Estimate time saved: 55m

BUILD SUCCESSFUL in 26m 35s
1258 actionable tasks: 529 executed, 546 from cache, 183 up-to-date
➜  spring-boot git:(fix-EqualityRulesRecipes) ✗

@Pankraz76 Pankraz76 mentioned this pull request Dec 30, 2025
Closed
@Pankraz76
Pankraz76 force-pushed the fix-EqualityRulesRecipes branch 2 times, most recently from b752591 to bac4896 Compare December 30, 2025 16:47
@Pankraz76

Pankraz76 commented Dec 30, 2025

Copy link
Copy Markdown
Owner Author

Kindly asking, if this is something to consider?

@philwebb @wilkinsona

PS: merry xmas and a happy new year.

@Pankraz76
Pankraz76 marked this pull request as ready for review December 30, 2025 16:50
@Pankraz76
Pankraz76 force-pushed the fix-EqualityRulesRecipes branch 13 times, most recently from ce0da94 to cde72c6 Compare January 2, 2026 11:47
@Pankraz76 Pankraz76 changed the title Add EqualityRulesRecipes Add SanityCheck#EqualityRulesRecipes Jan 2, 2026
@Pankraz76
Pankraz76 force-pushed the fix-EqualityRulesRecipes branch 2 times, most recently from aab7a03 to 5067dc9 Compare January 2, 2026 12:55
Pankraz76
Pankraz76 commented Jan 2, 2026
View reviewed changes
Comment thread ...rc/test/java/org/springframework/boot/tomcat/servlet/TomcatServletWebServerFactoryTests.java
@@ -664,7 +664,7 @@ void whenServerIsShuttingDownARequestOnAnIdleConnectionResultsInConnectionReset(
Future<Object> idleConnectionRequest = initiateGetRequest(httpClient, port, "/");
Object result = idleConnectionRequest.get();
return result;
}, (result) -> result instanceof Exception);
}, Exception.class::isInstance);

@Pankraz76 Pankraz76 Jan 2, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

less seems more.

Pankraz76
Pankraz76 commented Jan 2, 2026
View reviewed changes
Comment thread .github/workflows/release.yml
@@ -70,7 +70,7 @@ jobs:
- verify
runs-on: ${{ vars.UBUNTU_SMALL || 'ubuntu-latest' }}
steps:
- name: Check Out Code
- name: Checkout Code 📥
uses: actions/checkout@v6

@Pankraz76 Pankraz76 Jan 2, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uses: actions/checkout@v6
uses: actions/check-out@v6

accoding to kebak-case command uses one word just like git itself.

Vincent Potucek
Add SanityCheck#EqualityRulesRecipes
d210486 
Signed-off-by: Vincent Potucek <vpotucek@me.com>
@Pankraz76
Pankraz76 force-pushed the fix-EqualityRulesRecipes branch from d860887 to d210486 Compare January 2, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Pankraz76