Skip to content

[prone] Apply NonStaticImport & StaticImport#6

Merged
Pankraz76 merged 3 commits into
mainfrom
pr-fix-StaticImport
Oct 21, 2025
Merged

[prone] Apply NonStaticImport & StaticImport#6
Pankraz76 merged 3 commits into
mainfrom
pr-fix-StaticImport

Conversation

@Pankraz76

Copy link
Copy Markdown
Owner

Please DO NOT FORCE PUSH. Don't worry about messy history, it's easier to do code review if we can tell what happened after the review, and force pushing breaks that.

Please make sure that your PR allows edits from maintainers. Sometimes it's faster for us to just fix something than it is to describe how to fix it.

Allow edits from maintainers

After creating the PR, please add a commit that adds a bullet-point under the [Unreleased] section of CHANGES.md, plugin-gradle/CHANGES.md, and plugin-maven/CHANGES.md which includes:

  • a summary of the change
  • either
    • a link to the issue you are resolving (for small changes)
    • a link to the PR you just created (for big changes likely to have discussion)

If your change only affects a build plugin, and not the lib, then you only need to update the plugin-foo/CHANGES.md for that plugin.

If your change affects lib in an end-user-visible way (fixing a bug, updating a version) then you need to update CHANGES.md for both the lib and all build plugins. Users of a build plugin shouldn't have to refer to lib to see changes that affect them.

This makes it easier for the maintainers to quickly release your changes :)

@Pankraz76
Pankraz76 marked this pull request as ready for review October 21, 2025 09:46
@Pankraz76
Pankraz76 force-pushed the pr-fix-StaticImport branch from 11d9c56 to 275d41e Compare October 21, 2025 09:48
// Test worktree 1
{
RepositorySpecificResolver repositorySpecificResolver = GitWorkarounds.fileRepositoryResolverForProject(project1Tree);
Assertions.assertThat(repositorySpecificResolver.getGitDir()).isEqualTo(project1GitDir);

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dry.dry

@Pankraz76
Pankraz76 merged commit 32214c8 into main Oct 21, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant