fix(backend): re-raise RuntimeError when no pass matched in pass_mgr_direct#96
Open
xjtu-L wants to merge 1 commit into
Open
fix(backend): re-raise RuntimeError when no pass matched in pass_mgr_direct#96xjtu-L wants to merge 1 commit into
xjtu-L wants to merge 1 commit into
Conversation
…direct When the backend raises RuntimeError (no pass matched), dynamo internally catches it and falls back to eager execution. The _CompileOnceWrapper then returns the eager result normally, causing the test framework to incorrectly report "success" instead of "failed". This patch detects the fallback (optimized_gm is None) and re-raises RuntimeError, making the behavior consistent with pass_mgr.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
_CompileOnceWrapper.forward, when_torch_compile_backendraisesRuntimeErrordue to no pass matching, Dynamo internally catches the exception and falls back to eager execution.self._compiled(*args, **kwargs)then returns the eager result normally —_optimized_gmremains None but no exception is thrown, causing the test framework to incorrectly report no-match cases assuccess.Fix
Detect
_optimized_gm is Noneinforward(the sign of Dynamo fallback), and re-raiseRuntimeErrorso the test framework correctly marks the case asfailed, consistent withpass_mgrbehavior.Impact
Only affects status reporting of no-match cases (
success→failed). Does not affect pass matching or execution logic.