Add pack deprecation and removal workflow by breferrari · Pull Request #13 · PackWeave/registry

breferrari · 2026-03-25T08:54:23Z

Summary

Support deprecated = true and optional deprecated_message in [pack] section of pack.toml
Propagate deprecation fields to packs/{name}.json and index.json
Auto-remove orphaned packs/*.json when src/ directory is deleted (pack removal)
Document both workflows in CONTRIBUTING.md

Weave compatibility

New JSON fields are safe — PackMetadata, PackListing, and PackRelease structs use #[serde(default)] and silently ignore unknown fields. No Weave changes needed.

Test plan

All 13 packs generate with identical output (no deprecation flags set)
Verified deprecation flow works with manual test
Orphan cleanup logic verified
CI passes

Closes #8

🤖 Generated with Claude Code

The regex-based parse_pack_toml() worked for simple flat fields but would break on multiline strings, inline tables, or other valid TOML constructs. Switch to Python's stdlib tomllib (3.11+) for spec-compliant parsing. Pin Python 3.12 in CI via actions/setup-python to guarantee tomllib availability regardless of runner image updates. Output is byte-for-byte identical to the regex-based parser for all 13 current packs. Closes #5 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Add validate_pack() and validate_unique_server_names() that check: - Required fields (name, version, description) - Name format (lowercase, digits, hyphens, no trailing hyphen) - Semver format (X.Y.Z) - authors/keywords are string lists - [[servers]] syntax (not [servers]) - Server names: format, uniqueness within and across packs - Server command/url required based on transport type Validation runs before generation on every invocation. Add --validate-only flag for local/CI use without writing files. Add validate.yml workflow that runs on PRs touching src/** or scripts/generate.py so contributors get feedback before merge. Closes #6 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Add deprecation support: - Read deprecated/deprecated_message from [pack] in pack.toml - Propagate to packs/{name}.json and index.json - Print [DEPRECATED] warnings during generation Add removal support: - Remove orphaned packs/*.json when src/ directory is deleted - Ensures removed packs disappear from index.json Document both workflows in CONTRIBUTING.md. New fields are safe for Weave — PackMetadata and PackListing structs use serde defaults and silently ignore unknown fields. Closes #8 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Copilot

Pull request overview

Adds first-class support for pack deprecation/removal in the registry generator, plus CI/docs to standardize these workflows across contributions.

Changes:

Parse pack.toml with tomllib, validating pack metadata and server definitions; add --validate-only mode.
Propagate deprecated / deprecated_message into generated packs/*.json and deprecation flags into index.json, and remove orphaned packs/*.json when a pack is deleted from src/.
Document deprecation/removal steps in CONTRIBUTING.md and add a PR validation workflow; ensure publish workflow provisions Python 3.12.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
scripts/generate.py	TOML parsing + validation, deprecation propagation, orphan cleanup, `--validate-only` CLI
CONTRIBUTING.md	Documents deprecation and removal workflows
.github/workflows/validate.yml	Adds PR-time validation job using `--validate-only`
.github/workflows/publish.yml	Ensures Python 3.12 is installed before generation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-25T08:59:08Z

+        return errors
+
+    seen_server_names: set[str] = set()
+    for i, server in enumerate(servers):


validate_pack() assumes each entry in servers is a dict and calls server.get(...). If a pack.toml has servers = [...] (array of scalars) or otherwise contains a non-table element, validation will raise an AttributeError and crash instead of reporting a useful error. Add an isinstance(server, dict) check (and emit an error like "server #N must be a table") before accessing .get().

Suggested change

for i, server in enumerate(servers):

for i, server in enumerate(servers):

if not isinstance(server, dict):

errors.append(f"{pack_dir_name}: server #{i + 1} must be a table")

continue

Copilot · 2026-03-25T08:59:08Z

+        except (ValueError, tomllib.TOMLDecodeError):
+            continue
+
+        for server in data.get("servers", []):


validate_unique_server_names() iterates for server in data.get("servers", []) and then calls server.get(...). If servers is not a list (e.g. [servers] table) or contains non-table elements, this will throw and prevent the script from reaching the "Validation failed" path. Guard that servers is a list of dicts (similar to validate_pack()), or reuse the already-validated servers structure from the validation pass.

Suggested change

for server in data.get("servers", []):

servers = data.get("servers")

if not isinstance(servers, list):

continue

for server in servers:

if not isinstance(server, dict):

continue

Copilot · 2026-03-25T08:59:08Z

+    # Required fields
+    for field in ("name", "version", "description"):
+        if field not in pack or not pack[field]:
+            errors.append(f"{pack_dir_name}: missing required field '{field}' in [pack]")
+
+    name = pack.get("name", "")
+    if name and not _NAME_RE.match(name):
+        errors.append(
+            f"{pack_dir_name}: invalid pack name '{name}' — "
+            "must be lowercase letters, digits, and hyphens only"
+        )


validate_pack() doesn't enforce that required scalar fields (name, version, description) are strings. If someone accidentally writes an unquoted TOML value (e.g. version = 1), the later regex checks (_NAME_RE.match(...) / _SEMVER_RE.match(...)) will raise a TypeError and crash validation. Add explicit isinstance(..., str) checks for these fields and report a validation error when the type is wrong.

- Add isinstance check for [pack] section (must be a table, not scalar) - Add string type checks for required fields (name, version, description) - Guard server entries with isinstance(server, dict) checks - Harden validate_unique_server_names() against non-list/non-dict servers - Skip cross-pack validation when per-pack errors already exist - Use consistent `python` (not `python3`) in CI workflows - Add scripts/generate.py to publish.yml path triggers Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

breferrari and others added 3 commits March 25, 2026 09:51

Copilot AI review requested due to automatic review settings March 25, 2026 08:54

Copilot started reviewing on behalf of breferrari March 25, 2026 08:54 View session

breferrari mentioned this pull request Mar 25, 2026

Add SHA-256 checksums to pack version entries #14

Open

4 tasks

Copilot AI reviewed Mar 25, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add pack deprecation and removal workflow#13

Add pack deprecation and removal workflow#13
breferrari wants to merge 4 commits into
mainfrom
feat/deprecation-workflow

breferrari commented Mar 25, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 25, 2026

Uh oh!

Copilot AI Mar 25, 2026

Uh oh!

Copilot AI Mar 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-        for server in data.get("servers", []):
+        servers = data.get("servers")
+        if not isinstance(servers, list):
+            continue
+        for server in servers:
+            if not isinstance(server, dict):
+                continue

Uh oh!

Conversation

breferrari commented Mar 25, 2026

Summary

Weave compatibility

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants