belief file csv output#483
Open
josephvanpeltkw wants to merge 6 commits into
Open
Conversation
Purg
reviewed
Apr 16, 2025
| ) | ||
| self.pv_image_frame_id = ( | ||
| self.declare_parameter("pv_image_frame_id", "PVFramesBGR") | ||
| self.declare_parameter("pv_image_frame_id", "/kitware/pv_image_detections_2d")#"PVFramesBGR") |
Member
There was a problem hiding this comment.
I would have expected this to just need to be "pv_image_detections_2d", and the namespace under which the bag play happens does appropriate namespace prepending to messages emitted?
Purg
reviewed
Apr 16, 2025
| rgb_image = bridge.imgmsg_to_cv2(msg, msg.encoding) | ||
|
|
||
| if "rgb" in msg.encoding: | ||
| rgb_image = cv2.cvtColor(rgb_image, cv2.COLOR_BGRA2RGBA) |
Member
There was a problem hiding this comment.
Is L575 not outputting an RGB image already when the msg.encoding is "rgb"? It looks like you're converting form "BGR" to "RGB" here, but I would have expected rgb_image to already be in RGB at this point (its just maybe missing the alpha channel?).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add new script to output the belief file csv