Skip to content

Refactor audio message to Dialogue Utterance#384

Open
derkmed wants to merge 19 commits into
PTG-Kitware:masterfrom
derkmed:dialogue_utterance
Open

Refactor audio message to Dialogue Utterance#384
derkmed wants to merge 19 commits into
PTG-Kitware:masterfrom
derkmed:dialogue_utterance

Conversation

@derkmed

@derkmed derkmed commented Feb 2, 2024

Copy link
Copy Markdown
Contributor

This is the first of several mini-PRs that will cover the changes proposed in #378

We should remove the previously used messages upon confirmation of working implementation.

@derkmed derkmed force-pushed the dialogue_utterance branch from 834a8aa to ea4224c Compare February 2, 2024 16:56
@derkmed derkmed force-pushed the dialogue_utterance branch from 61bb218 to 7b3409f Compare February 2, 2024 17:21
@derkmed

derkmed commented Feb 2, 2024

Copy link
Copy Markdown
Contributor Author

@Purg @hdefazio @joshanderson-kw This should be in a reviewable state. It refactors all nodes to use a new general purpose message that allows on-the-fly re-ordering or removal of audio nodes depending on compute-latency constraints.

The next PRs will attempt to bring ASR + VAD locally, add visual question answering, and add @ovenmitt 's demo changes.
Please review as soon as possible to unblock these upcoming changes.

@hdefazio

Copy link
Copy Markdown
Contributor

@derkmed can you rebase on the latest master?

@Purg

Purg commented May 20, 2024

Copy link
Copy Markdown
Member

@derkmed Is this relevant anymore with the more recent PR of yours (#418) having landed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants