Executions info panel tweaks#776
Conversation
…xecutions_info-panel-tweaks
…xecutions_info-panel-tweaks
…xecutions_info-panel-tweaks
…tiator, previousVersionName
…xecutions_info-panel-tweaks
|
|
…xecutions_info-panel-tweaks
jjoderis
left a comment
jjoderis
left a comment
There was a problem hiding this comment.
Very nice UI.
One thing I'm not sure about is the fact that we show no information at all when no instance is selected. Some of the data exists outside the instance like the "Process/Step image", "Planned" Budget, some of the information in "Details" and the existing Variables shown in "Data". So it might make sense to show that data even when no instance is selected.
| <EntryKeyText key="instance-name-key">Name</EntryKeyText>, | ||
| <EntryValueText key="instance-name-value">{definitionsInfos?.name}</EntryValueText>, |
There was a problem hiding this comment.
I thought that you could have new component return the rows you currently create after the fact in your "DataGrid" component directly so you can decide in that function if you need two or one column.
So something along these lines:
const EntryComponent: React.FC<...> = (...) => {
...
if (isHeader) {
return (
<Row ...>
<Col ...>
...
</Col>
</Row>
)
}
return (
<Row ...>
<Col ...>
...
</Col>
<Col ...>
...
</Col>
</Row>
)
}
| ) : performers ? ( | ||
| !!performers?.length && ( | ||
| <Space> | ||
| {performers.map((e) => | ||
| !e.isGuest ? ( | ||
| <Tag color={'purple'} key={e.id + 'assigned'}> | ||
| {e.firstName + ' ' + e.lastName} | ||
| </Tag> | ||
| ) : undefined, | ||
| )} | ||
| </Space> |
There was a problem hiding this comment.
Since you are getting this information from the bpmn anyway now you could maybe skip the "logInfo" case above and always show this information.
There was a problem hiding this comment.
If I understood correctly there wont be any entries for events that happened yet. So in that case the only way is to fetch the userdata from their IDs given in the bpmn.
This comment has been minimized.
This comment has been minimized.
|
✅ Successfully created Preview Deployment. |
3 participants
Summary
This branch started as little tweaks for the instance info panel but evolved to a whole revamp of the panel and most of it's components.
Details