Installation script#846
Open
maxbriel wants to merge 2 commits into
Open
Conversation
sgossage
reviewed
Jun 10, 2026
Comment on lines
+206
to
+209
| if [[ -z "$DATA_PATH" ]]; then | ||
| print_error "Path cannot be empty!" | ||
| continue | ||
| fi |
Contributor
There was a problem hiding this comment.
I think it could be good to check for pre-existing datasets and/or if $PATH_TO_POSYDON_DATA already exists and give an option to use that.
Contributor
It looks like we have a warning that guides users on what to do if |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A script to simplify the installation of POSYDON, setup the environment, and download the data.
The idea is that the user only has to run the command below, which downloads and starts the script. The script guides the user through the POSYDON installation.
Important
Requires
condato already be installed! I can adapt the code to also check the operating system + installcondaif not install. Is that's something we want?Co-written with Claude Sonnet 4.6