Conversation
fixed indentation of docstring in `dataset.Dataset.split_train_other(...)`
added qutations to all dataset citations since ":" were interfering with proper parsing in select cases
conversion of mRECIST values needed for some PDX datasets. The formatting function of coderdata returns a DF with the mRECIST column having dtype 'str'. Previously 'floats' where assigned to the values causing a TypeError. Note the datasets still have a typo of mRESCIST.
for the improve framework to work properly study identifiers in the split file names and the respones have to be of the same case. This fix is implemented such that this is guaranteed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR contains several fixes to:
prepare_data_for_improve.py:strto guarantee compatibility with other value typesdataset.ymlcitationsfield toStringto prevent faulty parsing using the pythons yaml parser