Springkyannap2026#8
Open
kyannap02 wants to merge 38 commits into
Open
Conversation
Chaniel Merge 4/24
Josiah Merge 4/24
Merge 4/24
Early commit to be able to clone during class on laptop 9 errors (mostly simple fixes) SDK issue with firebase need to reinstall likely
…nto ChanielFirebase
Josiah UI changes
Chaniel firebase
- Reset Placed flag when re-selecting a placed object so it can be freely moved before re-confirming placement (prevents double-click from immediately re-firing Place() and destroying ObjectDrag) - Guard against duplicate ObjectDrag components on repeated clicks - Show placement UI (highlightButtons) when initializing a new object - Fix CalculateSizeInCells using local zeros instead of Vertices array, causing TakeArea/UnfillArea to always operate on a 0x0 grid area Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The Vertices[i] fix made CanBePlaced check real grid tiles for the first time, blocking placement against pre-existing tilemap tiles. Reverting to vertices[i] restores the original placement behavior while the core editing bug fixes remain intact. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
fixed issue issue that didnt allow user to double click object and reselect objects for deletion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1st attempt:
BuildingSystem.cs:SelectObject()objectToPlace.UpdateState(false, true)to resetPlaced = falseso the object can be freely moved again, and guards against duplicateObjectDragcomponentsBuildingSystem.cs:InitializeWithObject()unhighlightButtons()→highlightButtons()so placement UI shows when adding a new objectPlaceableObject.cs:CalculateSizeInCells()vertices[i]→Vertices[i]so grid size is calculated from actual collider corners, not all zeros