Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/src/services/keycloak_admin/user_handler.py
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ def add_user(
user_id = location.rstrip("/").split("/")[-1]

# Trigger "Update Password" email
kc.execute_actions_email(realm_name, token, user_id, ["UPDATE_PASSWORD"])
# kc.execute_actions_email(realm_name, token, user_id, ["UPDATE_PASSWORD"])

# Determine org manager flag from requested role
is_org_manager = (role or "").strip().upper() == "ORG_MANAGER"
Expand Down
38 changes: 19 additions & 19 deletions api/test/services/test_keycloak_admin_coverage.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,25 +77,25 @@ def test_create_realm_with_smtp_and_required_actions(mock_kc):
assert payload["clients"] == template["clients"]
assert payload["users"] == template["users"]

def test_add_user_triggers_email(mock_kc):
# Arrange
uh = user_handler()
session = MagicMock()

mock_response = MagicMock(
status_code=201,
headers={"Location": "http://keycloak/u/123"}
)
mock_kc.create_user.return_value = mock_response
mock_kc.get_realm_role.return_value = {"id": "r1"}

# Act
uh.add_user(session, "realm", "user", "pass", "Full Name", "user@test.com", "ORG_MANAGER")

# Assert
mock_kc.execute_actions_email.assert_called_once_with(
"realm", ANY, "123", ["UPDATE_PASSWORD"]
)
# def test_add_user_triggers_email(mock_kc):
# # Arrange
# uh = user_handler()
# session = MagicMock()
#
# mock_response = MagicMock(
# status_code=201,
# headers={"Location": "http://keycloak/u/123"}
# )
# mock_kc.create_user.return_value = mock_response
# mock_kc.get_realm_role.return_value = {"id": "r1"}
#
# # Act
# uh.add_user(session, "realm", "user", "pass", "Full Name", "user@test.com", "ORG_MANAGER")
#
# # Assert
# mock_kc.execute_actions_email.assert_called_once_with(
# "realm", ANY, "123", ["UPDATE_PASSWORD"]
# )

def test_add_user_location_missing(mock_kc):
uh = user_handler()
Expand Down
6 changes: 3 additions & 3 deletions api/test/services/test_user_handler.py
Original file line number Diff line number Diff line change
Expand Up @@ -131,9 +131,9 @@ def test_create_user_success(service, mock_kc, session: Session):
# Assert
assert res["status"] == "created"
assert res["username"] == "john.doe"
mock_kc.execute_actions_email.assert_called_once_with(
realm_name, "token", "123", ["UPDATE_PASSWORD"]
)
# mock_kc.execute_actions_email.assert_called_once_with(
# realm_name, "token", "123", ["UPDATE_PASSWORD"]
# )

# Verify DB
db_user = session.get(User, "123")
Expand Down
Loading