fix(macos): demo-blocking polish + stable dev signing#5
Merged
Conversation
Three issues that would look bad on camera, plus the signing fix for the "re-authorize on every rebuild" pain: - AudioCaptureService.checkPermission was a query with side effects: it set a verbose lastError (surfaced as a red banner) and opened System Settings on its own. That fired even when the ViewModel was about to fall back to microphone-only capture, so screen-recording denial showed a scary error instead of silently degrading. Made it a pure query; the VM now owns the decision (mic fallback vs. a concise actionable notice). - The Ollama status indicator showed "stopped" on launch until first use, because nothing probed it. Probe checkStatus()/checkHealth() in the VM initializer so the indicator reflects reality immediately. - Stable local code-signing identity: ad-hoc signatures change every build, invalidating TCC permissions and forcing re-authorization each time. package-app.sh now signs with a stable "LCT Dev" identity when present (ad-hoc fallback for CI), and scripts/dev-cert.sh creates it once. Also investigated an intermittent launch-time auto-capture: not reproducible on clean launch (5/5 idle); appears to have been lingering instances during rapid test cycling. Latent risk noted: window-close-doesn't-quit + global hotkeys could allow multi-instance confusion (follow-up: single-instance guard). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prep for recording a demo video. Fixes three on-camera issues + the rebuild re-auth pain.
Fixes
checkPermissionwas a query with side effects (set a verbose red-banner error + opened System Settings) that fired even when the VM was about to fall back to microphone-only. Now a pure query; VM owns the decision.checkStatus()/checkHealth()so the indicator is correct immediately.package-app.shsigns with a stableLCT Devidentity when present (ad-hoc fallback for CI);scripts/dev-cert.shcreates it once.Investigated, not reproduced
Launch-time auto-capture appeared 4×, then 5/5 idle on clean launch. Likely lingering instances during rapid test cycling. Latent risk noted: window-close-doesn't-quit + global hotkeys → possible multi-instance confusion (follow-up: single-instance guard).
Verified
🤖 Generated with Claude Code