Upgrade to HTTP.jl 2.x - #302
Conversation
9e433f0 to
a44304b
Compare
|
@ndortega This passes now, but I think there are enough changes that this strictly speaking should require an Oxygen 2.x . I can put this together with an upgrade guide in this PR if wanted. |
|
Found a bug in staticfiles after a bit of dogfooding. Will fix and report back. |
* Increases minimum Julia version to 1.11 * Deprecates :stream, :access_log, and :queuesize * Creates new name queryparams(...) shadowing and dispatching to URIs rather than re-exporting from HTTP.jl
9ae779d to
d4df3a9
Compare
|
Okay I've fixed the staticfiles issue and outlined how this is currently a bit surprising at JuliaWeb/HTTP.jl#1333 In the future it might be an idea to deprecate staticfiles/dynamicfiles and use HTTP.jl 2.x's own capabilities; see: https://juliaweb.github.io/HTTP.jl/stable/guides/server/#Static-Files . However, the ecosystem is rapidly adopting HTTP.jl 2.x so I think it might be best to make a fairly compatible release first, and then move to evolving the Oxygen.jl API and adopting more performant patterns later. |
|
Hi @frankier, I just wanted to thank you for putting this PR together! I'll be going through it this weekend to provide some feedback. I don't see any reason why we can't get this merged within the next week |
2 participants
Closes #299
PR is tool assisted but reviewed and manually polished.
This PR upgrades to HTTP.jl.
One wrinkle here is that access_log is removed completely. Perhaps we should have a middleware for this built in and install it when access_log is not
nothing.Another is that
queryparamsis removed. In this PR the shadow-and-dispatch-to-the-original pattern is used with URIs.queryparams is used to avoid type piracy and keep reasonable compatibility with old code.