Don't build a Rust test harness for the bindings crate - #860
Merged
Conversation
crates/oxen-py has no Rust tests, and is not the right place for them: it is a thin PyO3 binding layer, so a Rust test would exercise PyO3's interface more than our own logic. That logic lives in liboxen and is tested through the Python suite, which exercises the bindings against the module maturin builds. Building the harness anyway is not free. A test target is an executable, so it embeds libpython rather than resolving symbols at load time the way the cdylib does, and PyO3 emits the matching rpath only when the interpreter is a framework build. Against a plain shared interpreter the harness aborts at launch, before libtest starts, so `cargo test --workspace` fails with no test failure to point at.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe ChangesPython Test Configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
jcelliott
marked this pull request as ready for review
August 12, 2026 16:09
Contributor
|
🏎️ 💨 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crates/oxen-py has no Rust tests, and is not the right place for them: it is a thin PyO3 binding layer, so a Rust test would exercise PyO3's interface more than our own logic. That logic lives in liboxen and is tested through the Python suite, which exercises the bindings against the module maturin builds.
Building the harness anyway is not free. A test target is an executable, so it embeds libpython rather than resolving symbols at load time the way the cdylib does, and PyO3 emits the matching rpath only when the interpreter is a framework build. Against a plain shared interpreter the harness aborts at launch, before libtest starts, so
cargo test --workspacefails with no test failure to point at.