Stop contending for the shared rayon pool when summing entry sizes - #854
Open
CleanCut wants to merge 1 commit into
Open
Stop contending for the shared rayon pool when summing entry sizes#854CleanCut wants to merge 1 commit into
CleanCut wants to merge 1 commit into
Conversation
`compute_entries_size` summed a single `u64` field across a slice via `into_par_iter`. Summing `u64`s is memory-bandwidth-trivial, so the split and work-steal overhead can never pay for itself, and the call occupies liboxen's process-global rayon pool while it does. That pool is shared with work that genuinely parallelizes — merkle-tree unpack in `fs_merkle_node_store::write_nodes` and per-repo storage sizing in `namespaces` — so an unjustified `par_iter` here is pure contention for those workers. This was the only CPU-bound rayon call site in liboxen; the remaining three parallelize filesystem latency, where overlapping I/O waits is the point. ENG-1250
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe entry size calculation in ChangesEntry size calculation
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need to send entries to individual threads in a thread pool in order to read their
num_bytesfield. 🤣ENG-1250