Improve note spendability short circuited#28
Draft
zancas wants to merge 7 commits into
Draft
Conversation
zancas
changed the title
zancas
force-pushed
the
improve_note_spendability_short_circuited
branch
from
February 12, 2026 00:26
56373c6 to
96bf20c
Compare
zancas
force-pushed
the
improve_note_spendability_short_circuited
branch
from
February 12, 2026 01:15
cc30b59 to
2e98914
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not certain that it's impossible for a ScannedWithoutMapping to be rescanned even though local state (the client) "knows" there are 0 unspent notes below it.
If unnecessary rescans can be avoided this will improve sync performance as a function of a few variables including network dependent (throughput, availability, etc.) ones.
This PR implements a check that short circuits rescan of ScannedWithoutMapping in the case that there are 0 unspent notes below the range that would be rescanned.
By recursing on the check the implementation ensures that all contiguous ScannedWithoutMapping ranges a correctly handled... i.e. simple switched to scanpriority "Scanned".