fix: Decommissioning zero-state vaults with empty portfolio

[matteoettam09]

Summary by CodeRabbit

• Bug Fixes

  • Updated vault decommissioning finalization condition to recognize additional states where portfolios are fully liquidated.

• Tests

  • Added test suite covering vault decommissioning completion scenarios, including edge cases with zero portfolios and non-underlying positions.

[coderabbitai]

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

The PR expands vault decommissioning completion logic to recognize empty portfolios with zero assets as fully liquidated, alongside the existing single-underlying-asset condition. A test harness method is added for direct testing, supported by a comprehensive test suite validating state transitions across zero-state, 100% underlying, and blocked-completion scenarios.

Changes

Vault Decommissioning Portfolio Liquidation

Layer / File(s)	Summary
Portfolio liquidation condition expansion contracts/LiquidityOrchestrator.sol	The portfolioLiquidated check in _processSingleVaultOperations now recognizes portfolios as fully liquidated when either a single position equals the underlying asset (existing behavior) or when token count is zero and final total assets are zero (new behavior), enabling decommissioning finalization under these expanded conditions.
Test harness method exposure contracts/test/LiquidityOrchestratorHarness.sol	A new external function exposed_processSingleVaultOperations delegates vault operation parameters to the internal _processSingleVaultOperations method, exposing the decommissioning logic for direct testing without state-modifying computation.
Decommissioning test suite test/VaultDecommissioning.test.ts	Comprehensive Hardhat test suite with full contract deployment infrastructure, helper functions (createVault, processVaultEpochState), and four targeted test cases: zero-state vault with empty portfolio completes decommissioning; 100% underlying portfolio completes decommissioning; non-underlying positions block completion; non-zero final assets with empty tokens block completion.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related issues

• OrionFinanceAI/protocol-bug-bounty#85: The logic change to broaden portfolioLiquidated condition to include empty portfolio + zero final assets case directly addresses the code-level fix described in this issue.

Possibly related PRs

• OrionFinanceAI/protocol#200: Both PRs modify the _processSingleVaultOperations decommissioning completion condition in LiquidityOrchestrator.sol by adjusting when completeVaultDecommissioning is permitted based on portfolio liquidation state.

Poem

🐰 A vault is emptied, assets flee,
Two paths now lead to harmony—
One token left, the underlying way,
Or zero both—decommission's day!
Tests confirm the rabbit's lair,
Liquidation, clean and fair.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix: Decommissioning zero-state vaults with empty portfolio' directly and specifically describes the primary change made in this PR: broadening the condition for finalizing decommissioned vaults to include zero-state vaults with empty portfolios.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch dev

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}