feat(atmosphere): Hillarie Phisically Based Atmosphere Shader#444
Open
mate-h wants to merge 2 commits into
Open
feat(atmosphere): Hillarie Phisically Based Atmosphere Shader#444mate-h wants to merge 2 commits into
mate-h wants to merge 2 commits into
Conversation
Collaborator
|
Awesome! We will merge it in next version. Hope more features/params could be implemented in future! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow up pull request to:
#376
I have separated out the atmosphere code as a separate package. It is open for feedback, some of the parameters like sun radius, displaySun are not working yet, but I will add those features back in subsequent commits as well as expose and improve the cloud coverage settings.
Demo screenshot