Allow using both template engines#120
Merged
hishamco merged 1 commit intoMay 18, 2026
Merged
Conversation
The `-t|--template` option now supports a new value, `TemplateEngine.Both`, and sets it as the default value. This improves flexibility by allowing an additional template engine.
Member
|
Could you please add a quick unit test to avoid such accidental breaks Thanks |
Member
|
We need to publish a patch release after this immediately |
Contributor
Author
Unfortunately the CommandLineApplication is not testable, as we cannot test the Execute Method. To tell you the truth I added some tests to check that no exception is raised when you provide the correct args, but i did not published them, as the correct way to do it is to test the Execute callback with mocking the actual extractor. We need to check if the processors where added to the engine, if -t is not passed. |
Member
|
I will check how I can test this later Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
-t|--templateoption now supports a new value,TemplateEngine.Both, and sets it as the default value. This improves flexibility by allowing an additional template engine.closes #119