Skip to content

Allow using both template engines#120

Merged
hishamco merged 1 commit into
OrchardCoreContrib:mainfrom
MichaelPetrinolis:fix_template_default_options
May 18, 2026
Merged

Allow using both template engines#120
hishamco merged 1 commit into
OrchardCoreContrib:mainfrom
MichaelPetrinolis:fix_template_default_options

Conversation

@MichaelPetrinolis

Copy link
Copy Markdown
Contributor

The -t|--template option now supports a new value, TemplateEngine.Both, and sets it as the default value. This improves flexibility by allowing an additional template engine.

closes #119

The `-t|--template` option now supports a new value, `TemplateEngine.Both`, and sets it as the default value. This improves flexibility by allowing an additional template engine.
@hishamco

Copy link
Copy Markdown
Member

Could you please add a quick unit test to avoid such accidental breaks

Thanks

@hishamco

hishamco commented May 18, 2026

Copy link
Copy Markdown
Member

We need to publish a patch release after this immediately

@MichaelPetrinolis

Copy link
Copy Markdown
Contributor Author

Could you please add a quick unit test to avoid such accidental breaks

Thanks

Unfortunately the CommandLineApplication is not testable, as we cannot test the Execute Method.

To tell you the truth I added some tests to check that no exception is raised when you provide the correct args, but i did not published them, as the correct way to do it is to test the Execute callback with mocking the actual extractor. We need to check if the processors where added to the engine, if -t is not passed.

@hishamco hishamco merged commit 9be6b0f into OrchardCoreContrib:main May 18, 2026
1 check passed
@hishamco

Copy link
Copy Markdown
Member

I will check how I can test this later

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Latest version (1.3.0) broke the default template options

2 participants