feat(text-area): allow to fix the height of the component despite the number of entered lines#1329
Open
paulinea wants to merge 5 commits into
Conversation
🟢 Netlify deploy for commit 85995db succeededDeploy preview: https://6a26dd412580092ba75c7050--ouds-android.netlify.app |
| * @param outputTransformation An optional [OutputTransformation] that transforms how the contents of the text field are presented. | ||
| * @param interactionSource An optional hoisted [MutableInteractionSource] for observing and emitting [Interaction]s for this text area. Note that if `null` | ||
| * is provided, interactions will still happen internally. | ||
| * @param fixedHeight Controls the height behavior of the text area. When `true`, the height is fixed and will not expand as text is entered. Otherwise, the |
Member
There was a problem hiding this comment.
In Figma's overview, the documentation talks about "Auto-resize". Should we rename this parameter to autoResize for consistency?
Member
Author
There was a problem hiding this comment.
Yes, you're right. I didn't see Maxime's update.
| val helperLink: OudsTextInputHelperLink? = null | ||
| ) | ||
|
|
||
| internal data class OudsTextAreaMultiLineValuePreviewParameter( |
Member
There was a problem hiding this comment.
This class is unused and can be removed.
| theme: OudsThemeContract, | ||
| lineCount: Int | ||
| fixedHeight: Boolean | ||
| ) = OudsPreview(modifier = Modifier.padding(all = PreviewPaddingDefault), theme = theme) { |
Member
There was a problem hiding this comment.
I don't know if the name of the preview should be PreviewOudsTextAreaMultiLineValue or PreviewOudsTextAreaFixedHeight, in order to be consistent with PreviewOudsTextAreaConstrainedMaxWidth. What do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.