feat: update alert message, inline alert, button, checkbox item, radio button item, switch item, suggestion chip, filter chip, link, tag and text input to allow the use of fixed images#1320
Conversation
11 tasks
🟢 Netlify deploy for commit 2ee85c8 succeededDeploy preview: https://6a1965539e55fe817897a8fe--ouds-android.netlify.app |
florentmaitre
force-pushed
the
1316-update-alert-message-inline-alert-button-checkbox-item-radio-button-item-switch-item-suggestion-chip-filter-chip-link-tag-and-text-input-to-allow-the-use-of-fixed-images
branch
from
6dc659d to
158033a
Compare
florentmaitre
force-pushed
the
1316-update-alert-message-inline-alert-button-checkbox-item-radio-button-item-switch-item-suggestion-chip-filter-chip-link-tag-and-text-input-to-allow-the-use-of-fixed-images
branch
from
158033a to
21b8b0d
Compare
florentmaitre
force-pushed
the
1316-update-alert-message-inline-alert-button-checkbox-item-radio-button-item-switch-item-suggestion-chip-filter-chip-link-tag-and-text-input-to-allow-the-use-of-fixed-images
branch
from
21b8b0d to
59a7ce1
Compare
# Conflicts: # core/src/main/java/com/orange/ouds/core/component/OudsAvatar.kt
florentmaitre
force-pushed
the
1316-update-alert-message-inline-alert-button-checkbox-item-radio-button-item-switch-item-suggestion-chip-filter-chip-link-tag-and-text-input-to-allow-the-use-of-fixed-images
branch
from
59a7ce1 to
ec06092
Compare
florentmaitre
force-pushed
the
1316-update-alert-message-inline-alert-button-checkbox-item-radio-button-item-switch-item-suggestion-chip-filter-chip-link-tag-and-text-input-to-allow-the-use-of-fixed-images
branch
from
3c49b6d to
a315d9f
Compare
florentmaitre
force-pushed
the
1316-update-alert-message-inline-alert-button-checkbox-item-radio-button-item-switch-item-suggestion-chip-filter-chip-link-tag-and-text-input-to-allow-the-use-of-fixed-images
branch
from
a315d9f to
9baa167
Compare
florentmaitre
force-pushed
the
1316-update-alert-message-inline-alert-button-checkbox-item-radio-button-item-switch-item-suggestion-chip-filter-chip-link-tag-and-text-input-to-allow-the-use-of-fixed-images
branch
from
9baa167 to
fde0aa1
Compare
paulinea
requested changes
Jun 10, 2026
| if (result == Modifier) element else result | ||
| } | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Not related to this PR but the Modifier extension last() no longer seems to be used.
| * Creates an instance of [OudsTagAsset.Icon]. | ||
| * | ||
| * @param painter Painter of the icon. | ||
| * @param tinted Controls whether the icon should be tinted with the theme color. Defaults to `true`. |
Member
There was a problem hiding this comment.
Maybe we can also add samples with non-tinted icon?
| onCheckedChange = { hasIcon = it }, | ||
| enabled = iconSwitchEnabled | ||
| ) | ||
| CustomizationSwitchItem( |
Member
There was a problem hiding this comment.
As discussed together, we should replace the "Tinted icon" switch and the "Icon" switch by chips with "Icon" label and "None", "Tinted", "Untinted" values.
This should be done in every components we have these 2 switches. For the others, that only have one "Tinted icon" switch, we can replace it by chips with 2 values.
| * - Functional statuses: [OudsIconBadgeStatus.Positive], [OudsIconBadgeStatus.Warning], [OudsIconBadgeStatus.Negative], [OudsIconBadgeStatus.Info]. | ||
| * Each functional status has its dedicated functional icon that matches the meaning of the badge. | ||
| * @param size The size of this badge. The icon is not displayed when size is [OudsBadgeSize.ExtraSmall] or [OudsBadgeSize.Small]. | ||
| * @param size The size of this badge. |
Member
There was a problem hiding this comment.
The badge is an exception, we don't allow to have a untinted icon here?
| * | ||
| * @param bitmap Image bitmap of the icon. | ||
| * @param contentDescription The content description associated with this [OudsButtonIcon]. This value is ignored if the button also contains label. | ||
| * @param tinted Controls whether the icon should be tinted with the theme color. Defaults to `true`. |
Member
There was a problem hiding this comment.
Should we precise in these comments that, for an untinted icon, they must ensure sufficient contrast for accessibility reasons?
Member
There was a problem hiding this comment.
Should we allow untinted icon for OudsFloatingActionButton?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.