Java/iot3core: add retain span attribute#555
Merged
mathieu1fb merged 2 commits intoJul 7, 2026
Merged
Conversation
Signed-off-by: Mathieu LEFEBVRE <mathieu1.lefebvre@orange.com>
| receivedSpan.setAttribute(AttributeKey.stringKey("iot3.core.mqtt.topic"), | ||
| publish.getTopic().toString()); | ||
| receivedSpan.setAttribute(AttributeKey.booleanKey("iot3.core.mqtt.retain"), | ||
| publish.isRetain()); |
Member
There was a problem hiding this comment.
In python, the SDK only sets the flag when it is true; it is missing when retain is false. See python/iot3/src/iot3/core/mqtt.py#L345
What about tracking the retain flag for messages that are published in retain? Ditto, in python, it is set to true on published messafges psoted in retain, missing otherwise. See python/iot3/src/iot3/core/mqtt.py#L208
Collaborator
Author
There was a problem hiding this comment.
Thanks for the feedback, I will align the behaviour of the Java SDK with what you did.
Note: this attribute is only present for retained messages (received and published), absent otherwise. Signed-off-by: Mathieu LEFEBVRE <mathieu1.lefebvre@orange.com>
mathieu1fb
force-pushed
the
iot3core-add-retain-span-attribute
branch
from
6a7a5db to
6fcc8ff
Compare
ymorin-orange
approved these changes
Jul 7, 2026
ymorin-orange
left a comment
ymorin-orange
left a comment
Member
There was a problem hiding this comment.
- Simple enough Java code that I could actually understand the diff. ;-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new
A new
iot3.core.mqtt.retainspan attribute has been added to the Java IoT3 Core SDK consumer spans.Close #545
What to do
Review code change.