Add configurable LookInside server support#868
Conversation
21d1dec to
9cafecc
Compare
🤖 Augment PR SummarySummary: This PR makes the Example project’s debug inspector server configurable via environment variables, allowing selection between LookInsideServer and LookinServer (or disabling both). Changes:
Technical Notes: Release configurations exclude inspector-server-related source globs while debug builds can include one chosen server (defaulting to LookInside) unless explicitly disabled. 🤖 Was this summary useful? React with 👍 or 👎 |
|
|
||
| public func withDomain<T>(_ domain: String, perform: () throws -> T) rethrows -> T { | ||
| domains.append(domain) | ||
| defer { domains.removeAll { $0 == domain } } |
There was a problem hiding this comment.
withDomain appends domain then defer { domains.removeAll { $0 == domain } }, which will also remove any previously-registered occurrences of the same domain (and can break later lookups). Consider only removing the entry added by this call so nested/duplicate domains don’t wipe global state.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| .external(name: "OpenSwiftUI"), | ||
| .external(name: "Equatable"), | ||
| ] + privateFrameworkDependencies | ||
| ] + privateFrameworkDependencies + debugServerDependencies |
There was a problem hiding this comment.
appDependencies always includes debugServerDependencies, so Release configs may still link/embed LookInside/Lookin frameworks even though only some source files are excluded. If the intent is “Debug targets only”, you may want to ensure Release configurations don’t carry these dependencies at all.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #868 +/- ##
=======================================
Coverage 25.72% 25.73%
=======================================
Files 677 677
Lines 47008 47008
=======================================
+ Hits 12095 12096 +1
+ Misses 34913 34912 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary