#179 Make OpenStemmata a Python package#183
Open
clemsciences wants to merge 8 commits into
Open
Conversation
Member
|
Thanks a lot for this work ! As it is an important change, I think we need to discuss it between maintainers, and see how to accomodate with them. |
Member
|
I wonder if one option could not be to have a separate repo under OpenStemmata for the python package, and keep the 'working database' separate 🤔 |
Author
|
I think it could be possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main benefit of the suggested changes is to simply do
pip install -e .at the root of the project to install theopenstemmataproject. The best would be to host the code on Pypi so that a simplepip install openstemmatawill install the project.I also made code more Pythonic. I know this is a matter of taste.
The main drawback is that I moved all the data files into src/openstemmata. This change may break all previous scripts based on this project.
The next task will be to add a built-in reader in the package (see #178).