Skip to content

fix: remove old custom alert and update exports#258

Open
santipalenque wants to merge 1 commit into
mainfrom
fix/double-custom-alert
Open

fix: remove old custom alert and update exports#258
santipalenque wants to merge 1 commit into
mainfrom
fix/double-custom-alert

Conversation

@santipalenque
Copy link
Copy Markdown
Contributor

@santipalenque santipalenque commented May 27, 2026

Removing duplicated component, keeping same export name for compatibility

Summary by CodeRabbit

  • Refactor

    • Reorganized CustomAlert component file structure for improved code organization.
  • Tests

    • Removed test suite as part of the component restructuring.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 405c7bb0-a215-4d16-9c90-adcde0be8cc8

📥 Commits

Reviewing files that changed from the base of the PR and between 59d3f88 and b2f5a46.

📒 Files selected for processing (4)
  • src/components/index.js
  • src/components/mui/__tests__/custom-alert.test.js
  • src/components/mui/custom-alert.js
  • webpack.common.js
💤 Files with no reviewable changes (2)
  • src/components/mui/tests/custom-alert.test.js
  • src/components/mui/custom-alert.js
🚧 Files skipped from review as they are similar to previous changes (2)
  • src/components/index.js
  • webpack.common.js

📝 Walkthrough

Walkthrough

This PR updates export and build references to accommodate the CustomAlert component being moved from a flat file (custom-alert.js) to a directory-based module structure (CustomAlert/). Both the public re-export path and webpack entry configuration point to the new location.

Changes

Module Path Updates

Layer / File(s) Summary
Module export and webpack entry path updates
src/components/index.js, webpack.common.js
MuiCustomAlert re-export and webpack entry point are updated to reference the new CustomAlert directory structure instead of the previous flat file.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • smarcet

Poem

🐰 A folder blooms where flat files stood,
Paths reshape as module trees should,
Exports and builders now point the way—
CustomAlert finds its new home today! 🌿

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main objective of the PR: removing the old CustomAlert component and updating its export path to maintain compatibility.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/double-custom-alert

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@santipalenque santipalenque force-pushed the fix/double-custom-alert branch from 59d3f88 to b2f5a46 Compare May 27, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant