Explain auto docu and fix NewFlowPostgres#262
Open
ostcar wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@bastianjoel The bug with the auto generation of the environment happens, because I never documented, how the environment system works.
I added some explanation, how the system was designed. I also changed the NewFlowPostgres function, to it behaves correctly.
You can find the necessary changes for a service here for the autoupdate: OpenSlides/openslides-autoupdate-service#1426
If you are ok with this change, then we have to fix the other go services as well.
If you don't like it, we have to discuss, how we solve it in another way. The current implementation breaks the idea behind the environment package.
Another way would be, if the Postgres-flow gets an "init" method that has to be called after NewFlowPostgres.
I like the returned init function better, because it makes it very hard to forget to call it. But an separate init method would be ok for me.