Vote detail view#6251
Open
Elblinator wants to merge 31 commits into
Open
Conversation
62 tasks
Elblinator
force-pushed
the
new-vote-detail
branch
from
8e40589 to
939ee12
Compare
Member
Author
|
If the poll list is opened first or and detail poll, then if any other poll detail is opened the list appears empty even while the votesDataSubject is correctly filled. I do not know why. Did I implem,ent something wrong or is anything missing @bastianjoel |
bastianjoel
reviewed
Jun 16, 2026
| pathMatch: `full`, | ||
| loadChildren: () => import(`./modules/poll-list/poll-list.module`).then(m => m.PollListModule) | ||
| loadComponent: () => | ||
| import('../../modules/poll/components/poll-list/poll-list.component').then(m => m.PollListComponent) |
Member
There was a problem hiding this comment.
I would prefer to have the poll list and detail related components (poll-detail, poll-entitled-users, poll-list, poll-single-votes) in app/site/pages/meetings/pages/polls/components. They are not used within other components and therefore do not really fit into the poll module.
|
|
||
| @Input() | ||
| public set votesDataObservable(observable: Observable<BaseVoteData[]>) { | ||
| public set votesDataObservabl(observable: Observable<BaseVoteData[]>) { |
Member
There was a problem hiding this comment.
Suggested change
| public set votesDataObservabl(observable: Observable<BaseVoteData[]>) { | |
| public set votesDataObservable(observable: Observable<BaseVoteData[]>) { |
Comment on lines
+79
to
+82
| public isDetailLink = computed(() => { | ||
| return window.location.pathname === this.getDetailLink(); | ||
| }); | ||
|
|
Member
There was a problem hiding this comment.
I would prefer an input for this.
|
|
||
| public constructor() { | ||
| super(); | ||
| super.setTitle(`Singular poll`); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.