Skip to content

[vote] Complete export_helper, tests and docs#3608

Merged
rrenkert merged 12 commits into
OpenSlides:feature/votefrom
vkrasnovyd:complete-tests
Jun 8, 2026
Merged

[vote] Complete export_helper, tests and docs#3608
rrenkert merged 12 commits into
OpenSlides:feature/votefrom
vkrasnovyd:complete-tests

Conversation

@vkrasnovyd

@vkrasnovyd vkrasnovyd commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Note that some of the old code (especially in the tests) is not from main but from #3167

Most common changes are based on the changed collections:

  • (old) poll_config_option -> (new) poll_option
  • (old) vote or ballot -> (new) poll_ballot
  • (old) relation between option and poll through poll_config -> (new) poll_option has own poll_id field and has no direct relation to the poll_config
  • for all poll_config_* collections: (old) no required fields -> (new) onehundred_percent_base is required
  • moved fields from poll to config collections
  • changes in available options for onehundred_percent_base
  • deleted meeting.*_default_backend fields

Extra:

  • started creating polls and related models manually, without requests to vote service, deleted unused methods (according to the concept, only delete requests can be sent from the backend to the new vote service);
  • temporary commented out migration tests and decreased minimum coverage to 93% to be able to keep updating the branch while other services are still being developed. Marked both changes as those that need to be reverted in the PR for merging feature/vote into main;
  • adjusted meeting export to correctly fetch the poll data, added a test with all the implemented config types;
  • deleted test_delete_with_poll_candidate as there's no separate model for poll candidates now: they are being set up as values of poll_option.meeting_user:

@vkrasnovyd vkrasnovyd self-assigned this Jun 4, 2026
@vkrasnovyd vkrasnovyd marked this pull request as draft June 4, 2026 16:43
@vkrasnovyd vkrasnovyd force-pushed the complete-tests branch 2 times, most recently from bd2b3d6 to 0090a93 Compare June 4, 2026 20:13
@vkrasnovyd vkrasnovyd force-pushed the complete-tests branch 2 times, most recently from 1c2ec12 to 7033c6d Compare June 5, 2026 18:01
@vkrasnovyd vkrasnovyd force-pushed the complete-tests branch 2 times, most recently from 1c2ec12 to 7067460 Compare June 5, 2026 18:04
@vkrasnovyd vkrasnovyd requested a review from luisa-beerboom June 8, 2026 07:11
@vkrasnovyd vkrasnovyd marked this pull request as ready for review June 8, 2026 07:12
Comment thread tests/system/action/meeting/test_import.py Outdated
Comment thread tests/system/action/test_migration_route.py
Comment thread setup.cfg Outdated
@vkrasnovyd vkrasnovyd requested a review from luisa-beerboom June 8, 2026 12:20
@vkrasnovyd vkrasnovyd assigned rrenkert and unassigned luisa-beerboom Jun 8, 2026
@rrenkert rrenkert merged commit 6bba336 into OpenSlides:feature/vote Jun 8, 2026
4 of 5 checks passed
@vkrasnovyd vkrasnovyd deleted the complete-tests branch June 8, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants