feat: add page navigator to bottom of the page#2187
Open
aryansondharva wants to merge 2 commits into
Open
Conversation
## Summary This PR addresses issue OpenSignLabs#2162 by adding the page navigator at the bottom of the relevant page. ## Changes - Reused the existing page navigation / pagination component - Added the navigator at the bottom of the page - Kept the existing navigation logic unchanged - Improved usability by allowing users to move between pages without scrolling back to the top ## Related Issue Closes OpenSignLabs#2162
|
@aryansondharva is attempting to deploy a commit to the prafull 's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds Prev/Next page navigation controls to multiple PDF-related pages to improve document paging UX.
Changes:
- Import the shared
PrevNextcomponent into several pages. - Render
PrevNextunder the PDF viewer area with consistent centering/padding.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| apps/OpenSign/src/pages/TemplatePlaceholder.jsx | Adds PrevNext import and renders pager under the PDF area. |
| apps/OpenSign/src/pages/SignyourselfPdf.jsx | Adds PrevNext import and renders pager under the PDF area. |
| apps/OpenSign/src/pages/PlaceHolderSign.jsx | Adds PrevNext import and renders pager under the PDF area. |
| apps/OpenSign/src/pages/PdfRequestFiles.jsx | Adds PrevNext import and renders pager under the PDF area. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+2131
to
+2137
| <div className="flex justify-center py-2"> | ||
| <PrevNext | ||
| pageNumber={pageNumber} | ||
| allPages={allPages} | ||
| changePage={changePage} | ||
| /> | ||
| </div> |
Comment on lines
+2164
to
+2170
| <div className="flex justify-center py-2"> | ||
| <PrevNext | ||
| pageNumber={pageNumber} | ||
| allPages={allPages} | ||
| changePage={changePage} | ||
| /> | ||
| </div> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses issue #2162 by adding the page navigator at the bottom of the relevant page.
Changes
Related Issue
Closes #2162