Fix WAV chunk ordering and RIFF padding#232
Open
AnthonyRonning wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
datachunks that precede the mandatoryfmtchunk instead of emitting split WAV files without format metadatadatachunks and reserve their pad byte within the configured chunk-size limitu32conversions before constructing each split fileFormat rule
RIFF/WAVE allows optional and unknown chunks around the mandatory chunks, but
fmtmust precede wave data. Appendix A of EBU Tech 3285 reproduces this Microsoft RIFF/WAVE ordering rule.Validation
nix develop -c cargo fmt --all -- --checknix develop -c cargo clippy --locked --all-targets --all-features -- -D warningsnix develop -c cargo test --locked --all-features(215 passed, 16 ignored)