Remove unnecessary trace logs#221
Open
AnthonyRonning wants to merge 2 commits into
Open
Conversation
WalkthroughSensitive values were removed from password-reset, session, and logout trace logs. A source-scanning test now checks selected files for forbidden sensitive-data logging markers. ChangesSensitive logging safeguards
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
The container image sets
RUST_LOG=info, and the entrypoint preserves that configured value. This is preventive hardening; there is no evidence of production trace exposure.Logout and refresh-token revocation behavior is unchanged.
Validation
cargo fmt --all -- --checkcargo test security_invariants::request_time_logs_do_not_include_session_keys_tokens_or_reset_codes -- --exactcargo clippy --all-targets --all-features -- -D warningscargo test --all-features(214 passed, 16 database-backed tests ignored as expected)Summary by CodeRabbit