Prototype Tinfoil-backed Responses web search#172
Draft
AnthonyRonning wants to merge 6 commits into
Draft
Conversation
Remove the unused Kagi client and secret loading so Responses search behavior matches our live provider setup. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Replace ad-hoc reasoning flags with a ReasoningState enum and small helpers in stream_one_assistant_turn so the per-turn lifecycle is easier to reason about. Trailing assistant text after tool_calls is now logged and dropped instead of aborting the response, and an assistant turn that produces no content emits an empty placeholder message so the stream still closes cleanly. Drop the dead message_id argument from storage_task and align the finish_reason on tool-call MessageDone with the OpenAI 'tool_calls' spelling. On ResponseDone, defensively call mark_pending_items_incomplete and log at error level if any pending items remain so the sender invariant violation is loud and the DB never holds in_progress stragglers. Add multi-turn tool prompt builder tests covering single tool turns, multiple consecutive tool turns, system-prompt + tool turns, and truncation that preserves the most recent tool turn. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Wire the local Responses web_search tool to Tinfoil's MCP search endpoint so we can exercise the new agent loop without adopting provider-side web search flows yet. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
web_searchtool to Tinfoil's MCPsearchendpoint while keeping the existing local agent loopTINFOIL_API_KEY, handles the SSE-ish MCP envelope, and normalizes the returned payloadValidation
cargo test --manifest-path /Users/tony/Dev/OpenSecret/opensecret/Cargo.tomlNotes