Allow scheduled security audits to open issues#43
Merged
AnthonyRonning merged 1 commit intoJul 11, 2026
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe security audit workflow now grants its job token ChangesSecurity audit workflow
Estimated code review effort: 1 (Trivial) | ~2 minutes Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
issues: writeto the non-PRsecurity_auditjobWhy
The scheduled audit correctly detected a RustSec advisory, then
rustsec/audit-checkattempted to create a GitHub issue and failed with:The job already grants
checks: write, but the action also needsissues: writewhen reporting a newly detected vulnerability. This permission is scoped only to the push/scheduled audit job; the pull-request audit continues to run with read-only repository permissions.The vulnerable lockfile entry itself was fixed in #42. This follow-up ensures future scheduled findings can be reported successfully instead of failing during issue creation.
Validation
actionlint .github/workflows/security.ymlgit diff --checkA whole-repository
actionlintpass also identified existing warnings in the Docker and release workflows; those are unrelated to this change.Summary by CodeRabbit