Rename Agent Mode chats and sessions to tasks#642
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAgent Mode now presents sessions as tasks, uses “New task” defaults, rewrites selected errors and framework notices, and supports deferred task creation through project-root selection while preserving chat-mode behavior. ChangesAgent task experience
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant Sidebar
participant AgentMode
participant ProjectRootChooser
User->>Sidebar: Select New Task
Sidebar->>AgentMode: requestNewTask()
AgentMode->>AgentMode: wait for initialization and unlocked settings
alt project root exists
AgentMode->>AgentMode: createSession()
else project root missing
AgentMode->>ProjectRootChooser: chooseProjectRoot()
end
Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Deploying maple with
|
| Latest commit: |
4a84ffc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ab057a0a.maple-ca8.pages.dev |
| Branch Preview URL: | https://codex-agent-task-terminology.maple-ca8.pages.dev |
7cb82de to
160b5f1
Compare
| const LEGACY_AGENT_UNTITLED_TITLES: [&str; 4] = [ | ||
| "New agent session", | ||
| "Agent session", | ||
| "New chat", | ||
| "Untitled chat", | ||
| ]; |
There was a problem hiding this comment.
We don't need legacy / backwards compatibility stuff in this new code.
There was a problem hiding this comment.
Should be resolved now.
There was a problem hiding this comment.
oh shoot, resolving branch conflicts real quick
160b5f1 to
08627b0
Compare
08627b0 to
96b6400
Compare
|
Needs rebase. |
yeah I caught that just as I hit the review button |
96b6400 to
17d84f1
Compare
17d84f1 to
9174e56
Compare
AnthonyRonning
left a comment
There was a problem hiding this comment.
Requesting changes because this PR has expanded substantially beyond the terminology change described in #639.
The intended scope is to change user-facing Agent terminology from “chat/session” to “task,” while leaving internal session APIs, storage, and existing behavior unchanged.
This PR currently includes two additional categories of work:
- It changes New Task behavior, including initialization queuing, folder-selection flow, runtime startup parameters, and when an empty task is persisted.
- It introduces string matching and rewriting for messages and errors emitted by Goose.
The New Task behavior may be fixing a legitimate problem, but it should not be bundled into a terminology PR. Please revert those behavioral changes here. If the current New Task flow is broken or inadequate, document the existing behavior, the desired behavior, and the relevant edge cases in a separate issue, then address it in a focused PR with direct tests.
I also do not want Maple matching exact Goose prose and rewriting it. This is brittle, couples Maple to Goose’s English wording, and risks modifying content based on text rather than a structured signal. The tests confirm the string-matching implementation, but they do not make that integration boundary maintainable.
Please remove the Goose string-rewriting logic from this PR. If Goose exposes user-facing session terminology that Maple needs to translate, handle that separately through a structured design—for example, typed error/notice categories from Goose, or a single adapter that maps Goose events into Maple-owned enums and presentation copy. That design deserves its own issue and PR.
For this PR, please keep the changes narrowly limited to:
- Static user-facing Agent labels, descriptions, dialogs, tooltips, and accessibility text.
- Small shared-component parameters needed to display “chat” in Chat Mode and “task” in Agent Mode.
- Maple-owned user-facing error strings where changing the literal at its source is straightforward.
- The default visible Agent title changing from “New agent session” to “New task.”
Please do not include runtime-flow changes, new task-creation semantics, initialization state handling, or rewriting of unstructured Goose content. Once the PR is reduced to that scope, I’ll review it again.
|
Removed the two feature-specific runtime text rewriters so this PR remains a static Maple UI terminology change and does not scan or alter user or Goose text. What changed:
Validation: cargo test (123 passed), frontend tests, type checking, formatting, and linting all passed. This is included as the separate commit b4719d4. |
|
Thanks—removing both runtime text rewriters addresses my Goose/error-mapping concern. The other requested scope change is still outstanding. The PR still contains the New Task behavioral changes, including:
Those are functional changes, not terminology changes. Please remove them from this PR and restore the previous initialization, folder-selection, runtime-start, and session-creation behavior. I understand that the shared sidebar needs a mode-aware label and may need a small callback parameter so a button labeled “New Task” does not execute Chat Mode’s If the existing New Task action has a behavioral bug, please document it separately with the current behavior, desired behavior, and edge cases, then address it in a focused PR with direct tests. Please also update the PR description after removing this behavior; it currently still advertises initialization queuing and the disabled-state fix. Once that remaining behavior is separated, the terminology PR will match the requested scope. |
|
Updated: the latest head removes the remaining New Task behavior expansion so this PR is limited to the requested terminology change. What is now in place:
The separate transition/disabled-state improvement, including the current behavior, desired behavior, edge cases, persistence decision, and required direct tests, is tracked in #645. Relevant commits: Validation: 131 frontend tests and 123 Rust tests passed, along with type checking, formatting, |
AnthonyRonning
left a comment
There was a problem hiding this comment.
The requested scope changes are now addressed. The Goose/runtime string rewriting is removed, the New Task behavior work is separated into #645, and this PR is appropriately limited to user-facing terminology plus the minimal mode-aware sidebar routing.
Approved. Please squash and merge this PR.
Closes #639
Summary
Scope
This PR is a user-facing language change only:
createSession()flow only when Agent settings are unlocked; Chat Mode continues to use its existingaddChat()flow.The separate initialization/disabled-state behavior improvement is tracked in #645.
User impact
Agent Mode consistently presents durable work as tasks while Chat Mode retains chat terminology. Existing Agent history and internal session data remain unchanged.
Validation
bun run typecheckbun test— 131 passedbun run lint— 0 errors, 12 pre-existing warningscargo fmt --all -- --checkcargo test— 123 passedgit diff --check