Add compressor functionality to the tessellator#68
Draft
lmdiazangulo wants to merge 14 commits into
Draft
Conversation
lmdiazangulo
commented
May 8, 2026
lmdiazangulo
commented
Contributor
- Implemented Compressor class for merging coplanar quad surfaces.
- Updated StaircaseMesher to include compression option.
- Enhanced launcher to read compression settings from JSON input.
- Added tests for Compressor functionality.
- Implemented Compressor class for merging coplanar quad surfaces. - Updated StaircaseMesher to include compression option. - Enhanced launcher to read compression settings from JSON input. - Added tests for Compressor functionality.
- Add groups initialization check in addQuad() helper to prevent segfault - Fix compressSurfaces() to properly remove merged elements - Update test expectations for merged return value
Contributor
Author
|
@copilot fix this so the actions pass |
Agent-Logs-Url: https://github.com/OpenSEMBA/tessellator/sessions/2ab9c1cf-5df7-41b4-aa40-c9d80938a5af Co-authored-by: lmdiazangulo <4919398+lmdiazangulo@users.noreply.github.com>
Agent-Logs-Url: https://github.com/OpenSEMBA/tessellator/sessions/2ab9c1cf-5df7-41b4-aa40-c9d80938a5af Co-authored-by: lmdiazangulo <4919398+lmdiazangulo@users.noreply.github.com>
lmdiazangulo
changed the title
Contributor
Author
|
@copilot can you check what is wrong with the failing action and fix it? |
Agent-Logs-Url: https://github.com/OpenSEMBA/tessellator/sessions/e5974172-7eed-4d3b-a308-0d68b508b8c4 Co-authored-by: lmdiazangulo <4919398+lmdiazangulo@users.noreply.github.com>
Fixed in b3b9b63. The failure was a transient vcpkg dependency download error on Windows ( |
lmdiazangulo
changed the title
| addQuad(mesh, {2, 2, 0}, {3, 2, 0}, {3, 3, 0}, {2, 3, 0}); | ||
| // Corners to complete the ring | ||
| addQuad(mesh, {1, 0, 0}, {2, 0, 0}, {2, 1, 0}, {1, 1, 0}); | ||
| addQuad(mesh, {1, 3, 0}, {2, 3, 0}, {2, 2, 0}, {1, 2, 0}); |
Collaborator
There was a problem hiding this comment.
This quad has the opposite orientation (and thus a different normal to the rest).
| // - Top center (quad 8): cell x=1-2, y=2-3 | ||
| // - Bottom center (quad 7): cell x=1-2, y=0-1 | ||
| EXPECT_EQ(finalCount, 4u); | ||
| EXPECT_EQ(merged, 4u); // 8 - 4 = 4 surfaces merged |
Collaborator
There was a problem hiding this comment.
Final surfaces are not tested to check if original shape is maintained.
Comment on lines
+175
to
+177
| auto splitCount = core::Splitter::splitSurfaces(mesh); | ||
| EXPECT_EQ(splitCount, 4u); | ||
| EXPECT_EQ(countMeshElementsIf(mesh, isQuad), 4u); |
Collaborator
There was a problem hiding this comment.
Splitter should have its own tests that ensure the mesh is consistent.
Comment on lines
+294
to
+308
| corners[0](normalAxis) = grid[normalAxis][plane]; | ||
| corners[0](axis1) = grid[axis1][xCell]; | ||
| corners[0](axis2) = grid[axis2][yCell]; | ||
|
|
||
| corners[1](normalAxis) = grid[normalAxis][plane]; | ||
| corners[1](axis1) = grid[axis1][xCell + 1]; | ||
| corners[1](axis2) = grid[axis2][yCell]; | ||
|
|
||
| corners[2](normalAxis) = grid[normalAxis][plane]; | ||
| corners[2](axis1) = grid[axis1][xCell + 1]; | ||
| corners[2](axis2) = grid[axis2][yCell + 1]; | ||
|
|
||
| corners[3](normalAxis) = grid[normalAxis][plane]; | ||
| corners[3](axis1) = grid[axis1][xCell]; | ||
| corners[3](axis2) = grid[axis2][yCell + 1]; |
Collaborator
There was a problem hiding this comment.
The original quad coordinates are Relative. Getting the values directly from grid makes them absolute coordinates. They should stay Relative, making plane, xCell, xCell+ 1, yCell and yCell+ 1, the needed values.
Comment on lines
+77
to
+93
| if (compress_) { | ||
| log("Compressing surfaces.", 1); | ||
| std::size_t beforeQuads = countMeshElementsIf(mesh, isQuad); | ||
| std::size_t merged = Compressor::compressSurfaces(mesh); | ||
| std::size_t afterQuads = countMeshElementsIf(mesh, isQuad); | ||
| log("Compressed " + std::to_string(beforeQuads) + | ||
| " -> " + std::to_string(afterQuads) + | ||
| " quads (merged " + std::to_string(merged) + " surfaces)", 1); | ||
|
|
||
| log("Compressing lines.", 1); | ||
| std::size_t beforeLines = countMeshElementsIf(mesh, isLine); | ||
| merged = Compressor::compressLines(mesh); | ||
| std::size_t afterLines = countMeshElementsIf(mesh, isLine); | ||
| log("Compressed " + std::to_string(beforeLines) + | ||
| " -> " + std::to_string(afterLines) + | ||
| " lines (merged " + std::to_string(merged) + " segments)", 1); | ||
| } |
Collaborator
There was a problem hiding this comment.
Missing tests for meshing with compression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.