fix(kiosk): make the NFC hint arrows larger - #7
Merged
osayed0001 merged 1 commit intoAug 9, 2026
Conversation
The marching chevrons were too small to read across a room. Grow the arrow group (168×96dp) and the individual chevrons so they stand out next to the contactless symbol during the card step. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
hasan-ismail
added a commit
that referenced
this pull request
Aug 10, 2026
… be installed PR #7 built green, but green is not the same as shipped. It changed only NfcHint.kt and left every version field alone, so the build republished the SAME tag, :0.11.0-dev.7, with different content. Two consequences, both silent: 1. NOBODY CAN GET IT. OpenMasjidOS decides an app has an update by comparing the catalog's `version:` with the installed one. The catalog still said 0.11.0-dev.7 because the manifest still said 0.11.0-dev.7, so a box already on dev.7 sees no change, is never notified, and has nothing to install. This is exactly the failure mode CLAUDE.md rule 6b exists to prevent — a dev build that reuses a version is undetectable. 2. THE TAG MUTATED. The dev channel's whole integrity story is that :X.Y.Z-dev.N is an exact, immutable tag (that is what lets the compose pin a bare tag instead of a digest). Verified it moved: :0.11.0-dev.7 after PR #6's fix sha256:82f00a87d0ead9a03b0cb261064f09bfe81d9ed… :0.11.0-dev.7 now sha256:d609a187272f20e84569a9ed95993ff1073f6f48… So "dev.7" now names two different builds depending on when you pulled. A box that installed the first one reports dev.7 and is right; the registry says dev.7 and is also right; they are different software. Worth knowing if anything odd shows up on a box that updated in that window. The CI channel guard can't catch this: it checks the compose tag MATCHES manifest, and both were consistently dev.7. Consistent-but-stale passes. Nothing in the pipeline compares the version against what dev last published, which is why this needs a human or a habit rather than a check. Cheapest fix is the habit in rule 6b: the version bump belongs in the same push as the change it ships. dev.8 is content-identical to the mutated dev.7 plus the version fields, so this is purely about making PR #7 reachable. No changelog entry: the Unreleased section already describes the NFC hint, and this is a size tweak to a feature that has never shipped. Verified: server tsc clean, 120/120 tests, web tsc + build clean.
hasan-ismail
added a commit
that referenced
this pull request
Aug 13, 2026
The card step read "Tap, insert or swipe your card". Practically every card a masjid sees is contactless or chip, and naming a third option makes the one instruction a donor has to follow longer and vaguer at exactly the moment they are holding a card and deciding what to do. Now: "Tap or insert your card". Changed in the two places that produce that line — the reader's own input request (ReaderManager.onRequestReaderInput) and the fallback shown before the reader has said anything (GivingScreen.CardStep) — so the wording cannot come back from whichever fires first. NOT changed on purpose: a genuine swipe request from the reader. If a card can only be read by magstripe, the SDK says so through onRequestReaderDisplayMessage, and that is passed through untouched. Suppressing it would leave a donor holding a card the reader is asking them to swipe with nothing on screen telling them to — which is a worse failure than a slightly long prompt. NOT PUBLISHED. Hasan asked to hold this until the next change, so it is committed on dev but not pushed: pushing without a version bump would republish the :0.11.0-dev.21 tag with different content (the tag-mutation trap from PR #7), and bumping would offer an update he asked not to send yet. It goes out with whatever comes next.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The marching chevrons were too small to read across a room. Grow the arrow group (168×96dp) and the individual chevrons so they stand out next to the contactless symbol during the card step.