feat(summary): pin-termination steps in Winding Construction Steps#20
Closed
gpitel wants to merge 1 commit into
Closed
feat(summary): pin-termination steps in Winding Construction Steps#20gpitel wants to merge 1 commit into
gpitel wants to merge 1 commit into
Conversation
Author
|
Magnetic summary — Winding Termination section: before / after Before (upstream): no lead terminations in the summary. After (this PR): a dedicated Winding Termination section below the construction steps, labeling each lead as the start or end of its winding (e.g. "Start of 1-2 to Pin 2"). |
gpitel
force-pushed
the
claude/construction-step-pin-terminations
branch
4 times, most recently
from
41578ba to
7df3e91
Compare
Adds a dedicated Winding Termination section after the Winding Construction Steps: one entry per connection, grouped by winding (in functionalDescription order). Connections are ordered start-then-finish, so each entry names whether it is the start or end of the winding, the terminal type and the pin, e.g. "Start of Primary to Pin 3" / "End of Primary to Pin 4".
gpitel
force-pushed
the
claude/construction-step-pin-terminations
branch
from
7df3e91 to
a84cca1
Compare
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a Winding Termination section to the magnetic summary, in its own block after the Winding Construction Steps. It lists one step per lead — labeled as the start or end of its winding — naming the terminal type and pin, e.g.
Start of Primary to Pin 3/End of Primary to Pin 4.Notes
connections(type +pinName) fromfunctionalDescription, in array order (no sort). Connections are ordered start-then-finish, so the first lead is labeled "Start of" and the last "End of".toTitleCase(name.toLowerCase())) so all-caps names likePRIMARYrender asPrimaryrather thanP R I M A R Y.Screenshots
Before/after of the magnetic summary are in the comments below.