feat(wire): winding label + pin/connection editor in Wire Configuration#2
Closed
gpitel wants to merge 3 commits into
Closed
feat(wire): winding label + pin/connection editor in Wire Configuration#2gpitel wants to merge 3 commits into
gpitel wants to merge 3 commits into
Conversation
Author
|
Wire Configuration panel — winding label + connection editor: before / after Adds an editor for the winding's Label and a per-connection table — Name (pin), Type (terminal type), and Length (lead length, mm).
|
gpitel
force-pushed
the
claude/winding-connection-editor
branch
5 times, most recently
from
01addfd to
9132cc2
Compare
…ration Adds BasicLabelPinSelector.vue to edit a winding's name and its connections (pin name, terminal type and lead length) in the Wire Configuration panel. Connections are MAS metadata, so edits don't invalidate the wound geometry. The pin field is a dropdown when the bobbin declares pins, otherwise a free-text input; lead length is entered in mm and stored in metres, and the connection count is clamped to 2x numberParallels. Renaming a winding propagates to the construction references so name-matched derived views stay consistent.
gpitel
force-pushed
the
claude/winding-connection-editor
branch
from
9132cc2 to
5224d52
Compare
Extends the Wire Configuration pin/connection editor (BasicLabelPinSelector) with a blind (internal winding-to-winding) connection: - add "Blind" to the connection Type dropdown - when a row's type is Blind, render the Name field as an <input list> + <datalist> combobox: free text to mint a node id, plus a dropdown of blind node ids already used on any winding (pick one to join this winding to it) - disable the Length input on blind rows (an internal joint has no lead length) Two windings sharing the same Blind pinName are joined. "Blind" is a local string value (not yet in the generated MAS.ts ConnectionType enum) and round-trips to MAS verbatim. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
feat(wire): blind (winding-to-winding) connection type in pin editor
Author
|
Superseded by #3 — the clean |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a winding label + connection editor to the Wire Configuration panel (
BasicLabelPinSelector.vue), so a winding's name and its connections can be edited directly in the builder. Each connection row exposes Name (pinName), Type (terminal type) and Length (lead length).Notes
functionalDescription[].connections), so edits do not invalidate the wound geometry (nocleanCoil()).ConnectionTypeenum (Pin / Screw / SMT / Flying Lead).lengthin metres; leaving it blank omits the key.2 x numberParallels(physical wire ends), minimum 2.groups/sections/layersDescription,turnsDescription, bobbin connections) so name-matched derived views stay consistent.Screenshots
Before/after of the Wire Configuration panel are in the comments below.