Skip to content

ci: update condalock ci#2060

Open
atravitz wants to merge 8 commits into
mainfrom
ci/update_condalock_ci
Open

ci: update condalock ci#2060
atravitz wants to merge 8 commits into
mainfrom
ci/update_condalock_ci

Conversation

@atravitz

@atravitz atravitz commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

we're seeing the following error message in our runners:

https://github.com/OpenFreeEnergy/openfe/actions/runs/28533414925/job/84588529819

conda lock --with-cuda 11.8 -f environment-to-lock.yaml --lockfile openfe-conda-lock.yml 
usage: conda [-h] [-v] [--no-plugins] [-V] COMMAND ...
conda: error: argument COMMAND: invalid choice: 'lock' (choose from activate, check, clean, commands, compare, config, content-trust, create, deactivate, doctor, env, export, info, init, install, list, menuinst, notices, package, remove, rename, repoquery, run, search, token, tos, uninstall, update, upgrade)


LLM / AI generated code disclosure

LLMs or other AI-powered tools (beyond simple IDE use cases) were used in this contribution: no
If yes, please provide details here:

Checklist

  • All new code is appropriately documented (user-facing code must have complete docstrings).
  • Added a news entry, or the changes are not user-facing.
  • Ran pre-commit: you can run pre-commit locally or comment on this PR with pre-commit.ci autofix.
  • Filled in the AI generated code disclosure.

Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).

Developers certificate of origin

steps:
- name: Install conda-lock with Micromamba
uses: mamba-org/setup-micromamba@v2
uses: mamba-org/setup-micromamba@v3

@atravitz atravitz Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addresses node20 deprecation

@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.61%. Comparing base (97bef39) to head (6d7555c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2060      +/-   ##
==========================================
- Coverage   95.01%   90.61%   -4.40%     
==========================================
  Files         212      212              
  Lines       20572    20572              
==========================================
- Hits        19546    18642     -904     
- Misses       1026     1930     +904     
Flag Coverage Δ
fast-tests 90.61% <ø> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@atravitz

atravitz commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

it works! https://github.com/OpenFreeEnergy/openfe/actions/runs/28533965187

now reverting some of the pins that I don't think were actually needed and retesting here: https://github.com/OpenFreeEnergy/openfe/actions/runs/28538206077

@atravitz atravitz changed the title update condalock ci ci: update condalock ci Jul 1, 2026

- name: Upload file as artifact
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v6

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addresses node20 deprecation

steps:
- name: Download artifact
uses: actions/download-artifact@v4
uses: actions/download-artifact@v7

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addresses node20 deprecation

- name: Generate lock files
run: |
conda lock --with-cuda 11.8 -f environment-to-lock.yaml --lockfile openfe-conda-lock.yml
conda-lock --with-cuda 11.8 -f environment-to-lock.yaml --lockfile openfe-conda-lock.yml

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why this was breaking now, but this seems to resolve it.

@atravitz

atravitz commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

No API break detected ✅

View workflow run

Griffe output
$ griffe check "openfe" -s src --no-inspection --no-color --verbose -a origin/main

$ griffe check "openfecli" -s src --no-inspection --no-color --verbose -a origin/main

@atravitz atravitz requested a review from IAlibay July 1, 2026 19:20
@atravitz atravitz marked this pull request as ready for review July 1, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant