chore: ignore sentry errors by regexp#1440
Open
doc-han wants to merge 2 commits into
Open
Conversation
Collaborator
|
@doc-han this looks great, I love the approach One adjustment I'd like (which might change the approach) is that ideally the workflow should exit with state Crashed
I'd also love to see this reported on the
Can you have a think about what it would take to do that? I think it means you still might have to catch the exception earlier in the process |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Short Description
This PR allows us to ignore specific errors from going through sentry.
We currently don't want Oauth error to pass through sentry. hence we use a beforeSend hook in sentry to filter the errors
(in the image below, the error is intercepted and logged to not be reported to sentry)

Fixes #1429
Implementation Details
A more detailed breakdown of the changes, including motivations (if not provided in the issue).
QA Notes
On Lighting there's a branch that simulates Oauth always failing
Branch: https://github.com/OpenFn/lightning/tree/ignore-sentry-errors (
ignore-sentry-errors)debug:trueatkit/packages/ws-worker/src/server.ts
Lines 249 to 262 in 8e29d12
AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy
Release branch checklist
Delete this section if this is not a release PR.
If this IS a release branch:
pnpm changeset versionfrom root to bump versionspnpm installpnpm changeset tagto generate tagsgit push --tagsTags may need updating if commits come in after the tags are first generated.