Removed -march=native flag#16
Open
MJohnson459 wants to merge 1 commit into
Open
Conversation
This flag propogates to all users of the library which makes them non-portable. Users of the library can still enable this flag if they wish. The binary sets the flag privately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This flag propogates to all users of the library which makes them non-portable. Users of the library can still enable this flag if they wish. The binary sets the flag privately.
The
mfpmath=sseis also non-portable although less extremely. It is the default on x64 architectures.We could make these variables completely private to the library following modern cmake best practices but that would be a larger change.