Optimize the view algorithm#2565
Merged
Merged
Conversation
boring-cyborg
Bot
added
Client
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The view algorithm would loop over every tile in range several times, more times the larger the range was. It only updated each tile during one of the iterations and ignored them during the others though. The pattern they get updated in is easily predictable, so each tile only gets iterated on twice now (once in step 3, once in step 4).
This code in TestGame went from 6.8 seconds to 0.9 seconds (map size 1000x1000x1):
world.log << view(500, locate(500,500,1)):len