fix: bump epaper-dithering to 5.0.8 (tone=auto NaN collapse)#122
Merged
Conversation
epaper-dithering 5.0.6 collapses crisp bilevel bright images to an all-black frame under tone="auto" (log-skew strength goes NaN via (-x).powf(1.4)). 5.0.8 ships the fixed core. Verified against the real reproduction: bilevel white 800x480 frame + measured MONO palette + tone=auto now dithers correctly instead of returning 384000 black pixels.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
epaper-dithering ≤5.0.7 collapses crisp bilevel bright images to an all-black frame under
tone="auto": with ≥2% pure-black pixels the 2nd-percentile luminance is 0.0, the Reinhard log-skew strength lands epsilon-negative,(-x).powf(1.4)is NaN, and NaN resolves every pixel to palette index 0. Surfaced in the HA integration: any text-on-whitedrawcustomframe (odl-renderer output is unantialiased) uploaded as 69 compressed bytes of black.5.0.8 ships the fixed core (OpenDisplay/epaper-dithering#51 + core
6765760).Test plan
tone=auto→ correct histogram (was: 384,000 × black)pytest -q→ 517 passed🤖 Generated with Claude Code