Fix minor issues in update and services (NEW-3..NEW-6)#55
Merged
g4bri3lDev merged 1 commit intoJul 6, 2026
Merged
Conversation
- NEW-3: default _attr_release_notes at class level so async_release_notes() can't raise AttributeError before/without a successful GitHub fetch. - NEW-4: import ColorScheme from opendisplay (re-exported) instead of the undeclared direct epaper_dithering dependency. - NEW-5: add explicit aiohttp.ClientTimeout to all external HTTP calls (GitHub metadata 30s, firmware download 120s, media download 30s). - NEW-6: run blocking os.path.isdir font-dir checks in the executor. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012g2e8mr132vcizx92WsgiR
g4bri3lDev
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch of four small, surgical fixes to the HA integration.
async_release_notes()could raiseAttributeError—_attr_release_noteswas only assigned on the successful GitHub-fetch path, but RELEASE_NOTES is advertised for every device. Added a class-level_attr_release_notes: str | None = Nonedefault so calls before/without a successful fetch (e.g. unknown IC type, fetch failure) returnNone.epaper_ditheringimport —services.pyimportedColorSchemedirectly fromepaper_dithering, which is only present transitively via py-opendisplay. Now imported fromopendisplay, which re-exports it (confirmed at pinned v7.9.0).aiohttp.ClientTimeoutto every externalsession.get: GitHub metadata (30s) inupdate.py, firmware asset download (120s) inupdate.py, and media download (30s) inservices.py.os.path.isdiron the event loop —_font_search_dirsdoes blocking stat calls and is invoked from async_drawcustom_for_device; it now runs viahass.async_add_executor_job.Verified: both edited files pass
py_compile;ColorSchemeresolves fromopendisplayat v7.9.0. No test harness present in the repo.🤖 Generated with Claude Code
https://claude.ai/code/session_012g2e8mr132vcizx92WsgiR